Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to customise the configmap name #244

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

gouthamve
Copy link
Member

Signed-off-by: Goutham Veeramachaneni gouthamve@gmail.com

@gouthamve gouthamve requested a review from a team as a code owner January 11, 2021 18:26
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Don't forget a CHANGELOG entry.

cortex/config.libsonnet Outdated Show resolved Hide resolved
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
@gouthamve gouthamve merged commit 50c36f9 into grafana:master Jan 12, 2021
@gouthamve gouthamve deleted the customise-configmap branch January 12, 2021 11:59
simonswine pushed a commit to grafana/mimir that referenced this pull request Dec 20, 2021
…e-configmap

Add option to customise the configmap name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants