Add function to customize compactor statefulset #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
commented
Apr 2, 2021
| @@ -13,7 +13,7 @@ local utils = import 'mixin-utils/utils.libsonnet'; | |||
| $.containerMemoryWorkingSetPanel('Memory (workingset)', 'compactor'), | |||
There was a problem hiding this comment.
No change here because this function wants the container name not the job name (same for CPU panel). The container name doesn't change when you customize the statefulset.
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…on-to-create-compactor-statefulset Add function to customize compactor statefulset
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Dec 20, 2021
…on-to-create-compactor-statefulset Add function to customize compactor statefulset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
We have an use case where we need a custom compactor deployment. Similarly to what we did with
newIngesterStatefulSet()function, in this PR I'm proposing to addnewCompactorStatefulSet()function to allow to create a 2nd statefulset for the compactor.I've also updated the compactor dashboards to allow to customize the compactor job name, like we already do for other services (eg. see the ingester one).
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]