Added CortexKVStoreFailure alert #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
approved these changes
Oct 13, 2021
@pstibrany Definitely. I've update the alert to use the generic metric we have for KV store operations. WDYT? |
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
alert-on-consul-failures
branch
from
df3256e
to
be5af20
Compare
simonswine
pushed a commit
to grafana/mimir
that referenced
this pull request
Oct 18, 2021
…onsul-failures Added CortexFailingToTalkToConsul alert
pracucci
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In this PR I propose to add
CortexKVStoreFailurealert. The idea is to get an alert in case a Cortex instance is failing to talk to Consul (eg. Consul is down or there's a network partitioning).It's a warning alert to get more confidence, but idea is to move it to a critical alert if turnes out to work fine.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]