Skip to content

Commit

Permalink
docs: clarify webhook url segments and include port (#22)
Browse files Browse the repository at this point in the history
When deploying this webhook service, we noticed that the url specified
in the docs was missing the port which is assigned by default in the
code. If left unspecified, http will assume port 80, however the code
defaults to port 8000 unless explicitly set otherwise. This also
clarifies the strucuture of the url segments in the webhook.
  • Loading branch information
andrewbloom37 authored Feb 20, 2023
1 parent 984e8a9 commit a5af8f7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ spec:
- name: k6-load-test
timeout: 5m
type: pre-rollout
url: http://k6-loadtester.flagger/launch-test
url: http://<k6_loadtester_service_name>.<k6_loadtester_namespace>:<k6_loadtester_service_port>/launch-test
metadata:
script: |
import http from 'k6/http';
Expand All @@ -43,7 +43,7 @@ spec:
};
export default function () {
http.get('http://<your_service>-canary.<namespace>:80/');
http.get('http://<your_service>-canary.<namespace>:<service_port>/');
sleep(0.10);
}
upload_to_cloud: "true"
Expand Down
4 changes: 2 additions & 2 deletions example/canary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ spec:
name: k6-load-test
timeout: 5m
type: pre-rollout
url: http://k6-loadtester.flagger/launch-test
url: http://k6-loadtester.flagger:8000/launch-test
autoscalerRef:
apiVersion: autoscaling/v2beta2
kind: HorizontalPodAutoscaler
Expand All @@ -55,4 +55,4 @@ spec:
targetRef:
apiVersion: apps/v1
kind: Deployment
name: my-app
name: my-app

0 comments on commit a5af8f7

Please sign in to comment.