fix: Register processes for cleanup #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerok
force-pushed
the
zerok/fix-zombie-processes
branch
2 times, most recently
from
5fe6756
to
6f1dc5b
Compare
iainlane
reviewed
Jun 4, 2024
There was a problem hiding this comment.
nice find!
main thing i'm wondering: what would happen if we didn't have the limit and instead updated the code to always Wait() but still allow any number of children to be launched? it'd remove the need for the pool. but perhaps it's not advisable ...
left comments with not doing ☝️ in mind 🙂
zerok
force-pushed
the
zerok/fix-zombie-processes
branch
from
a11ccba
to
1decf46
Compare
iainlane
reviewed
Jun 5, 2024
Co-authored-by: Iain Lane <iain@orangesquash.org.uk>
zerok
force-pushed
the
zerok/fix-zombie-processes
branch
from
24ccad3
to
2287189
Compare
julienduchesne
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to register k6 TestRuns, for which we do not want to wait for a result, with a cleanup routine so that no zombie processes stay around.
Right now the number of handler go-routines (those that wait for the TestRun processes) are limited in number. If that limit is reached, then the HTTP handler becomes blocking.
Tasks
Resolves #152