Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Deprecate components available in @grafana/ui #115

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

Clarity-89
Copy link
Contributor

@Clarity-89 Clarity-89 commented Feb 2, 2024

  • Add deprecation warnings to the components that are available in grafana/ui to reduce the imports of those components from this package.
  • Remove the SecretInput and SecretTextArea components.

@Clarity-89 Clarity-89 self-assigned this Feb 2, 2024
src/ConfigEditor/Auth/common/SecretInput.tsx Outdated Show resolved Hide resolved
@@ -10,6 +10,9 @@ export interface SpaceProps {
layout?: 'block' | 'inline';
}

/**
* @deprecated use the Space component from @grafana/ui instead. Available starting from @grafana/ui@10.4.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10.4 is not released yet, but I've added this here to show that an alternative is available.

Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Clarity-89 Clarity-89 merged commit e3b16e2 into main Feb 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants