feat: Add new components to simplify migration from DataSourceHttpSettings #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasklacz
reviewed
Jun 29, 2023
sasklacz
approved these changes
Jun 29, 2023
joey-grafana
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
After copying over the new components to core in order to test, this seems to work well 👍
Note: I didn't review the code too much, I guess it's more or less the same as it was before you extracted it with maybe a few minor improvements. I'll leave that part to you and @sasklacz
Documentation is clear and concise.
src/ConfigEditor/docs-img/migrate-from-datasource-http-settings.png
Outdated
Show resolved
Hide resolved
SandersAaronD
pushed a commit
that referenced
this pull request
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ConnectionSettingsandAdvancedHttpSettingscomponents to simplify migration fromDataSourceHttpSettingscomponent.Screenshots of new components