Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add log for request start #1096

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Add log for request start #1096

merged 2 commits into from
Sep 26, 2024

Conversation

wbrowne
Copy link
Member

@wbrowne wbrowne commented Sep 25, 2024

Also uses this an as opportunity to convert existing log params to use camel case.

@wbrowne wbrowne self-assigned this Sep 25, 2024
@wbrowne wbrowne requested a review from a team as a code owner September 25, 2024 13:31
@wbrowne wbrowne requested review from marefr, andresmgot and xnyo and removed request for a team September 25, 2024 13:31
ivanahuckova
ivanahuckova approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also considering that these logs are relatively new, LGTM for renaming as well.

@wbrowne wbrowne merged commit 5b4c6d3 into main Sep 26, 2024
3 checks passed
@wbrowne wbrowne deleted the request-started-log branch September 26, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xnyo xnyo xnyo approved these changes

@ivanahuckova ivanahuckova ivanahuckova approved these changes

@gabor gabor Awaiting requested review from gabor

@marefr marefr Awaiting requested review from marefr marefr is a code owner automatically assigned from grafana/plugins-platform-backend

@andresmgot andresmgot Awaiting requested review from andresmgot andresmgot is a code owner automatically assigned from grafana/plugins-platform-backend

Assignees

@wbrowne wbrowne

Labels
None yet
Projects
Plugins Platform / Grafana Community
Status: 🚀 Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wbrowne @xnyo @ivanahuckova