Errorsource: mark protocol error as downstream #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwysiu
requested review from
wbrowne,
oshirohugo and
xnyo
and removed request for
a team
marefr
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
I think you rather want to/should validate this here https://github.com/grafana/grafana/blob/f403bc57d542cd07b27da0a24c4d94d32f452f97/pkg/tsdb/elasticsearch/elasticsearch.go#L167 and/or default to prefix with http:// if it's missing.
In general, I wonder why not treat any error here as downstream instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This error happens because the user sets a bad url, so it should be downstream. It's causing problems with the elasticsearch alerts.
Unfortunately because of the way it's declared, i don't have a better way to check for it than just checking for the string https://cs.opensource.google/go/go/+/master:src/net/http/transport.go;l=585?q=%22unsupported%20protocol%20scheme%22&ss=go%2Fgo
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: