Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-resizable-handle shows up in the panel editor #11771

Closed
ryantxu opened this issue Apr 27, 2018 · 8 comments · Fixed by #12107
Closed

react-resizable-handle shows up in the panel editor #11771

ryantxu opened this issue Apr 27, 2018 · 8 comments · Fixed by #12107
Assignees
@davkal
Labels
area/panel/common type/bug
Milestone
5.2.0-beta1

Comments

@ryantxu
Copy link
Member

ryantxu commented Apr 27, 2018

This is a super minor issue that I notice with recent builds, but do not remember in earlier 5x builds. When you go to the panel editor the bottom right now has a resize icon and changes the cursor. It does not do anything, but is a bit weird.

image
@daniellee daniellee added this to the 5.2 milestone Apr 30, 2018
@marefr marefr assigned Ijin08 and davkal and unassigned Ijin08 May 29, 2018
@marefr
Copy link
Member

marefr commented May 30, 2018

At the same time it would be nice to hide the icon in the lover right corner when in kiosk/inactive mode - please evaluate that in solution.

@davkal
Copy link
Contributor

davkal commented May 30, 2018

Cannot repro the resize issue on Chrome/Mac. Looking into icon hiding...

@marefr
Copy link
Member

marefr commented May 30, 2018

@davkal I can reproduce it on Ubuntu Chrome and Firefox

@davkal
Copy link
Contributor

davkal commented May 30, 2018

Aha, that's the browser's cursor for the CSS value cursor: se-resize;, just looks different on my machine. Anyways, I'm hiding the resize indicator in fullscreen panels and low-activity views. That should solve it.

@davkal davkal mentioned this issue May 30, 2018
Merged
marefr added a commit that referenced this issue May 30, 2018
@marefr
changelog: add notes about closing #11771
82ba27b 
[skip ci]
ryantxu added a commit to NatelEnergy/grafana that referenced this issue May 31, 2018
@ryantxu
Merge remote-tracking branch 'grafana/master'
f48b6f7 
* grafana/master:
  changelog: add notes about closing grafana#11771
  changelog: add notes about closing grafana#11971
  Fix singlestat threshold tooltip (grafana#12109)
  build: only runs db related tests on db.
  build: integration testing postegres on ci.
  build: mysql integration testing on ci.
  changelog: Second epochs are now correctly converted to ms.
  Fix CSS to hide grid controls in fullscreen/low-activity views
  provisioning: enable relative path's
  devenv: improve readme
  provisioning: place testfiles within testdata folder
  devenv: script for setting up default datasources
  devenv: scripts for generating many unique dashboards
@towolf
Copy link
Contributor

towolf commented Jun 1, 2018

This works with ?inactive but not with ?kiosk. @davkal did you intend for the controls to be hidden in kiosk mode as well?

@towolf
Copy link
Contributor

towolf commented Jun 1, 2018

Just found the comment on the PR:

IMO the difference between fullscreen and kiosk mode is that the latter is still interactive, just with no means of navigating away.

We use kiosk mode for fullscreen on wall-mounted TVs. I think hiding the controls is warranted there as well.

@marefr
Copy link
Member

marefr commented Jun 1, 2018

@towolf I was thinking that kiosk mode go into inactive mode eventually as well - maybe I was wrong?

@towolf
Copy link
Contributor

towolf commented Jun 1, 2018 •
edited
Loading

@marefr You're right, I did not expect that and did not wait long enough. The handles do disappear. That's ok then.

Even better, for our TVs this can be stacked: ?kiosk&inactive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davkal davkal

Labels
area/panel/common type/bug
Projects
None yet
Milestone
5.2.0-beta1
Development

Successfully merging a pull request may close this issue.

Fix CSS to hide grid controls in fullscreen/low-activity views grafana/grafana
6 participants
@towolf @daniellee @ryantxu @davkal @marefr @Ijin08