enable google analytics anonymizeIP setting #11656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanCech
added
type/bug
pr/early-feedback
jangaraj
reviewed
Apr 20, 2018
| var ga = ((<any>window).ga = | ||
| (<any>window).ga || | ||
| function() { | ||
| (ga.q = ga.q || []).push(arguments); | ||
| }); | ||
| ga.l = +new Date(); | ||
| ga('create', (<any>config).googleAnalyticsId, 'auto'); | ||
| ga('set', 'anonymizeIp', true); |
There was a problem hiding this comment.
I think this should be a config option. Some users may have a users authorisation to collect their full IP or their users are not in EU. Maybe also GA cookie lifetime should be configurable, because GDPR.
marefr
requested changes
Apr 26, 2018
There was a problem hiding this comment.
I would like to split this PR in two. One targeting the caching which we can include in v5.1.
The other PR for possible GDPR issues - here I would like an issue to be created so we can discuss requirements and possible solutions since we don't want to introduce new configuration options specifically for this. We still have 1 month to go before GDPR kicks in.
| @@ -7,14 +7,19 @@ export class Analytics { | |||
| constructor(private $rootScope, private $location) {} | |||
|
|
|||
| gaInit() { | |||
| $.getScript('https://www.google-analytics.com/analytics.js'); // jQuery shortcut | |||
| $.ajax({ | |||
There was a problem hiding this comment.
You can use getscript with cache:
$.getScript({
url: 'https://www.google-analytics.com/analytics.js',
cache: true,
});
DanCech
force-pushed
the
google-analytics
branch
from
beeb9bd
to
ab589da
Compare
DanCech
changed the title
|
merging but keeping #11739 open as this seems to only solve a small part of being GDPR compliant |
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
May 8, 2018
* grafana/master: (29 commits) renames alerting engine to match other services allow analytics.js to be cached, enable anonymizeIP setting (grafana#11656) Update CHANGELOG.md Revert "Add baron scrollbar to a node managed by gafana (grafana#11850)" fixed svg background (grafana#11848) Add baron scrollbar to a node managed by gafana (grafana#11850) Fix CSS asset loading for yarn start (HMR) (grafana#11855) fix: fixed gometalinter issues with Discord PR Update CHANGELOG.md docs: update installation instructions targeting v5.1.1 stable fix root_url in docs & comments (grafana#11819) changelog: 5.1.1 update fix: loading of css url (images/fonts) Support for local Docker builds fix: removed manully added http server from inject graph as it is now a self registered service fix: removed unused channel fix: comment spell fix fix: fixed race condition between http.Server ListenAndServe & Shutdown, now service crash during startup correctly closes http server every time refactoring: lots of refactoring around server shutdown flows, making sure process is terminated when background service has crashed refactor: provisioning service refactoring ...
marefr
added
cherry-pick needed
and removed
pr/early-feedback
ryantxu
added a commit
to ryantxu/grafana
that referenced
this pull request
May 8, 2018
* grafana/master: renames alerting engine to match other services allow analytics.js to be cached, enable anonymizeIP setting (grafana#11656)
ryantxu
added a commit
to NatelEnergy/grafana
that referenced
this pull request
May 8, 2018
* grafana/master: renames alerting engine to match other services allow analytics.js to be cached, enable anonymizeIP setting (grafana#11656) Update CHANGELOG.md Revert "Add baron scrollbar to a node managed by gafana (grafana#11850)"
marefr
added a commit
that referenced
this pull request
May 9, 2018
ryantxu
added a commit
to NatelEnergy/grafana
that referenced
this pull request
May 9, 2018
* grafana/master: changelog: add notes about closing grafana#11862, grafana#11656 Fix dependencies on Node v10 Update dashboard.md Adding a user in a specified organisation uses the admin API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #11739
This PR updates the google analytics code to use the anonymizeIP setting to avoid collecting the end user's IP address, this is important for GDPR compliance.
https://developers.google.com/analytics/devguides/collection/analyticsjs/field-reference#anonymizeIp
It also switches from
$.getScriptto$.ajaxfor loadinganalytics.jsso that we can avoid having jquery automatically append a timestamp query parameter which prevents the browser from caching it.