Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimePicker: Fixes hiding time picker dropdown in FireFox #19154

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

hugohaggmark
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes: #18531

Special notes for your reviewer:
You need to try this PR out in FireFox on MacOS

@hugohaggmark hugohaggmark added type/bug type/ux cherry-pick needed add to changelog area/grafana/ui Issues that belong to components in the @grafana/ui library labels Sep 17, 2019
@hugohaggmark hugohaggmark added this to the 6.4.0 milestone Sep 17, 2019
@hugohaggmark hugohaggmark self-assigned this Sep 17, 2019
@torkelo torkelo modified the milestones: 6.4.0, 6.4.0-beta1 Sep 17, 2019
@torkelo torkelo changed the title ButtonSelect: Fixes onBlur issue with FireFox on MacOS TimePicker: Fixes hiding time picker dropdown in FireFox Sep 17, 2019
@torkelo torkelo merged commit 3952083 into master Sep 17, 2019
@torkelo torkelo deleted the hugoh/button-select-on-blur-firefox branch September 17, 2019 07:48
@hugohaggmark
Copy link
Contributor Author

Thanks @torkelo for the cleaning up, wasn't certain if this was gonna make it to beta or not

@torkelo
Copy link
Member

torkelo commented Sep 17, 2019

np :)

ryantxu added a commit to ryantxu/grafana that referenced this pull request Sep 17, 2019
* grafana/master: (23 commits)
  API: adds redirect helper to simplify http redirects (grafana#19180)
  docs: image rendering (grafana#19183)
  Chore: Update latest.json (grafana#19177)
  Chore: Update version to next (grafana#19169)
  Docs: What's new in 6.4 update (grafana#19175)
  Devenv: create slow_proxy_mac (grafana#19174)
  Chore: Changelog for v6.4.0-beta1 (grafana#19171)
  Revert "Chore: Update Slate to 0.47.8 (grafana#18412)" (grafana#19167)
  Chore: Update Slate to 0.47.8 (grafana#18412)
  Changelog: Breaking changes and deprecation notes for v6.4 (grafana#19164)
  Docs: What's new 6.4 draft (grafana#19144)
  Docs: Add docs around feature toggles config (grafana#19162)
  Azure Monitor: Add support for cross resource queries (grafana#19115)
  Api: Readonly datasources should not be created via the API (grafana#19006)
  Explore: Update live tail buttons (grafana#19143)
  LDAP: only show tab if LDAP is enabled (grafana#19156)
  TimePicker: Fixes onBlur issue with FireFox on MacOS (grafana#19154)
  Feature: Encapsulated dynamic imports with error boundary and suspense (grafana#19128)
  Metrics: Adds setting for turning off total stats metrics (grafana#19142)
  Add directions for more details provided when not anymore on issue triage (grafana#19116)
  ...
ryantxu added a commit to ryantxu/grafana that referenced this pull request Sep 17, 2019
* grafana/master: (87 commits)
  API: adds redirect helper to simplify http redirects (grafana#19180)
  docs: image rendering (grafana#19183)
  Chore: Update latest.json (grafana#19177)
  Chore: Update version to next (grafana#19169)
  Docs: What's new in 6.4 update (grafana#19175)
  Devenv: create slow_proxy_mac (grafana#19174)
  Chore: Changelog for v6.4.0-beta1 (grafana#19171)
  Revert "Chore: Update Slate to 0.47.8 (grafana#18412)" (grafana#19167)
  Chore: Update Slate to 0.47.8 (grafana#18412)
  Changelog: Breaking changes and deprecation notes for v6.4 (grafana#19164)
  Docs: What's new 6.4 draft (grafana#19144)
  Docs: Add docs around feature toggles config (grafana#19162)
  Azure Monitor: Add support for cross resource queries (grafana#19115)
  Api: Readonly datasources should not be created via the API (grafana#19006)
  Explore: Update live tail buttons (grafana#19143)
  LDAP: only show tab if LDAP is enabled (grafana#19156)
  TimePicker: Fixes onBlur issue with FireFox on MacOS (grafana#19154)
  Feature: Encapsulated dynamic imports with error boundary and suspense (grafana#19128)
  Metrics: Adds setting for turning off total stats metrics (grafana#19142)
  Add directions for more details provided when not anymore on issue triage (grafana#19116)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/grafana/ui Issues that belong to components in the @grafana/ui library type/bug type/ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: ButtonSelect dropdown doesn't close on blur in Firefox
2 participants