CloudWatch: Surround dimension names with double quotes #22222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellee
added
datasource/CloudWatch
pr/external
|
This pull request has been automatically marked as stale because it has not had activity in the last 2 weeks. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
@sunker, could you review this? Or assign it to somebody? |
sunker
approved these changes
Mar 5, 2020
sunker
changed the title
bergquist
added a commit
to bergquist/grafana
that referenced
this pull request
Mar 6, 2020
* master: CloudWatch: updated namespaces - Athena, DocDB, and Route53Resolver (grafana#22604) Graph: Improve point rendering performance (grafana#22610) Alerting: Fix state age test failures (grafana#22606) Docs: Update image_rendering.md (grafana#22586) UI: Segment improvements (grafana#22601) remove section about alias imports (grafana#22585) Backend Plugins: Support handling of streaming resource response (grafana#22580) Stackdriver: Migrate GCE default project (grafana#22593) Toolkit: plugin ci needs to cooperate better with make/mage (grafana#22588) surround CloudWatch dimension names with double quotes (grafana#22222) Fix: when reloading page make sure that time picker history is converted to dateTime. Core: add active users stat (grafana#22563)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Places double quotes around the dimension names in the generated CloudWatch query.
Which issue(s) this PR fixes:
Fixes #22104.