Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudWatch: Add Route53 DNSQueries metric and dimension #25125

Merged
merged 7 commits into from
May 27, 2020

Conversation

erkolson
Copy link

What this PR does / why we need it:
Adds the AWS Cloudwatch Route53 DNSQueries metric

Which issue(s) this PR fixes:
n/a

@erkolson erkolson requested a review from a team as a code owner May 26, 2020 17:46
@erkolson erkolson requested review from bergquist and removed request for a team May 26, 2020 17:46
@CLAassistant
Copy link

CLAassistant commented May 26, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marefr marefr added this to the 7.1 milestone May 26, 2020
@marefr
Copy link
Member

marefr commented May 26, 2020

@erkolson thanks. Can you please rebase/merge with master and then we can merge this.

@marefr marefr changed the title Plugins: Add Route53 DNSQueries metric CloudWatch: Add Route53 DNSQueries metric and dimension May 26, 2020
@erkolson
Copy link
Author

I think this is up to date now, hopefully it can be merged before master is updated again 😆

@marefr marefr merged commit 3a63044 into grafana:master May 27, 2020
@marefr
Copy link
Member

marefr commented May 27, 2020

Thank you for contributing to Grafana!

aknuds1 pushed a commit that referenced this pull request Jun 30, 2020
Co-authored-by: Ilya Stoliar <52413756+ilyastoli@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants