AdminUsers: reset page to zero on query change #26293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hshoff
requested review from
a team,
mckn and
peterholmberg
and removed request for
a team
zoltanbedi
added
add to changelog
area/admin/user
cherry-pick needed
pr/external
zoltanbedi
approved these changes
Jul 13, 2020
There was a problem hiding this comment.
Thank you @hshoff for your contribution, this looks good to me.
dprokop
pushed a commit
that referenced
this pull request
Jul 16, 2020
(cherry picked from commit e63028e)
dprokop
pushed a commit
that referenced
this pull request
Jul 16, 2020
(cherry picked from commit e63028e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
/admin/usersto work no matter what page you are on (user search works only on page 1 #26209)Before if you searched for a user while on page 2 you would see empty results. This happens because page state does not get reset when query changes. The fix is to reset page to
0whenever the query changes.before
after
Which issue(s) this PR fixes:
Fixes #26209