Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudWatch: Update list of AmazonMQ metrics and dimensions #27332

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

szymonpk
Copy link
Contributor

@szymonpk szymonpk commented Sep 2, 2020

Update list of AmazonMQ metrics and Dimensions based on the current list
from the official AWS documentation.

Also, change InflightCount to InFlightCount.

What this PR does / why we need it:

List of metrics and dimensions is outdated, also InflightCount is now called InFlighCount (or always was like this)

Which issue(s) this PR fixes:

n/a

Special notes for your reviewer:

List of metrics and dimensions comes from https://docs.aws.amazon.com/amazon-mq/latest/developer-guide/security-logging-monitoring-cloudwatch.html

@szymonpk szymonpk requested a review from a team as a code owner September 2, 2020 12:00
@szymonpk szymonpk requested review from wbrowne and marefr and removed request for a team September 2, 2020 12:00
@CLAassistant
Copy link

CLAassistant commented Sep 2, 2020

CLA assistant check
All committers have signed the CLA.

Update list of AmazonMQ metrics and Dimensions based on the current list
from the official AWS documentation.

Also, change InflightCount to InFlightCount.
Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marefr marefr merged commit a8db544 into grafana:master Sep 2, 2020
@marefr
Copy link
Member

marefr commented Sep 2, 2020

Thank you for contributing to Grafana!

@marefr marefr added this to the 7.2 milestone Sep 2, 2020
@marefr marefr added area/backend pr/external This PR is from external contributor labels Sep 2, 2020
pull bot pushed a commit to digitalocean/grafana that referenced this pull request Sep 2, 2020
…7332)

Update list of AmazonMQ metrics and Dimensions based on the current list
from the official AWS documentation.

Also, change InflightCount to InFlightCount.
@szymonpk szymonpk deleted the cloudwatch-mq-fix-metric branch September 3, 2020 04:50
@marefr marefr changed the title Cloudwatch: Update list of AmazonMQ metrics and dimensions CloudWatch: Update list of AmazonMQ metrics and dimensions Sep 7, 2020
ryantxu pushed a commit that referenced this pull request Nov 18, 2020
Update list of AmazonMQ metrics and Dimensions based on the current list
from the official AWS documentation.

Also, change InflightCount to InFlightCount.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants