Explore: Fix showing of Prometheus data in Query inspector #28128
Conversation
ivanahuckova
requested review from
a team,
peterholmberg,
dprokop,
Elfo404,
kaydelaney and
zoltanbedi
and removed request for
a team,
peterholmberg,
dprokop and
Elfo404
ivanahuckova
changed the title
There was a problem hiding this comment.
This looks good to me. Nice job on adding tests. Can you please try to convert it to use react-testing-library? I think we agreed that we want to migrate to that and write new tests with that. Also in the future it might make sense to unify this inspector component with the one we have in dashboard.
| @@ -57,15 +57,15 @@ function stripPropsFromResponse(response: any) { | |||
| return clonedResponse; | |||
| } | |||
|
|
|||
| interface Props { | |||
| export interface Props { | |||
There was a problem hiding this comment.
It's really just a nit (and personal and totally opinionanted, so it's even less important than a nit 😄 ), but I personally would avoid exporting anything that is not really needed outside of a module as I feel it adds noise.
In this case, Props is not really needed outside of here apart from the test, in which case you can do:
import React, { ComponentProps } 'from 'react';
import { ExploreQueryInspector } from './ExploreQueryInspector';
type ExploreQueryInspectorProps = ComponentProps<typeof ExploreQueryInspector>;what do you think?
There was a problem hiding this comment.
Uuu I like it and I agree! Will update this. Thanks!
* Fix showing of data in explore's query inspector * Add test * Add test * Updat etest * Implement react-testing-library and remove props export * Update tests for consistency
What this PR does / why we need it:
When running Prometheus queries in Explore, the request and response wasn't shown in Inspector panel because if we have received response with
hideFromInspector === trueafter, the result was overwritten. This PR fixes it.Fixed:
Before:
