Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency: Adds Indonesian IDR currency #28363

Merged

Conversation

hiddenrebel
Copy link
Contributor

What this PR does / why we need it:
Add new option for Indonesian IDR currency
And Fix typo

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@hiddenrebel hiddenrebel requested review from a team, hugohaggmark and kaydelaney and removed request for a team October 19, 2020 11:30
@CLAassistant
Copy link

CLAassistant commented Oct 19, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@kaydelaney kaydelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution. You'll need to sign the contributor license agreement before this can be merged, however

@hiddenrebel hiddenrebel marked this pull request as draft October 22, 2020 04:41
Copy link
Contributor

@hugohaggmark hugohaggmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @kaydelaney, splendid work with this. You need to sign the CLA so we can merge this into master.

Also, I think you can use custom data units for this https://grafana.com/blog/2020/01/27/grafana-v6.6-released/#custom-data-units

@hiddenrebel
Copy link
Contributor Author

I agree with @kaydelaney, splendid work with this. You need to sign the CLA so we can merge this into master.

Also, I think you can use custom data units for this https://grafana.com/blog/2020/01/27/grafana-v6.6-released/#custom-data-units

sorry I am new here.
I try to sign the CLA and try to find out how to do it :D

I hope with this merge can help Indonesian user easy to use their own currency with the option that already exists

@ryantxu
Copy link
Member

ryantxu commented Oct 22, 2020

@hiddenrebel -- look up in this thread and you will see a post from the CLA assistant, it will look like:
image

Click on the part that says "not signed" and you will go to a form that lets you fill it out

thanks!

@hiddenrebel
Copy link
Contributor Author

@hiddenrebel -- look up in this thread and you will see a post from the CLA assistant, it will look like:
image

Click on the part that says "not signed" and you will go to a form that lets you fill it out

thanks!

i did it
image
but still can't sign

@hugohaggmark hugohaggmark marked this pull request as ready for review October 26, 2020 05:03
@hugohaggmark
Copy link
Contributor

@hiddenrebel -- look up in this thread and you will see a post from the CLA assistant, it will look like:
image
Click on the part that says "not signed" and you will go to a form that lets you fill it out
thanks!

i did it
image
but still can't sign

I think I understand why, the commit was commited by Muhammad Hendry and your github user is @hiddenrebel. You need to add the email adress for Muhammad Hendry to your github user. Thank you

@hiddenrebel
Copy link
Contributor Author

@hiddenrebel -- look up in this thread and you will see a post from the CLA assistant, it will look like:
image
Click on the part that says "not signed" and you will go to a form that lets you fill it out
thanks!

i did it
image
but still can't sign

I think I understand why, the commit was commited by Muhammad Hendry and your github user is @hiddenrebel. You need to add the email adress for Muhammad Hendry to your github user. Thank you

Awesome, thank you for your kind 👍
Thanks all for helping me. 😃

@hugohaggmark hugohaggmark changed the title Currency: Add Indonesian IDR currency Currency: Adds Indonesian IDR currency Oct 26, 2020
@hugohaggmark hugohaggmark merged commit 3abd995 into grafana:master Oct 26, 2020
@hugohaggmark hugohaggmark added this to the 7.4 milestone Oct 26, 2020
@hugohaggmark hugohaggmark added the pr/external This PR is from external contributor label Oct 26, 2020
aknuds1 pushed a commit that referenced this pull request Nov 3, 2020
@mjseaman mjseaman added this to the 7.4.0 milestone Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog pr/external This PR is from external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants