CloudWatch: Make it possible to specify custom api endpoint #31402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunker
requested review from
a team,
dsotirakis,
oddlittlebird,
achatterjee-grafana,
osg-grafana and
ivanahuckova
and removed request for
a team,
dsotirakis and
ivanahuckova
achatterjee-grafana
suggested changes
Feb 22, 2021
public/app/plugins/datasource/cloudwatch/components/ConfigEditor.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
…or.tsx Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
aknuds1
reviewed
Feb 23, 2021
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
approved these changes
Feb 23, 2021
osg-grafana
suggested changes
Feb 23, 2021
Co-authored-by: Ursula Kallio <73951760+osg-grafana@users.noreply.github.com>
osg-grafana
approved these changes
Feb 23, 2021
achatterjee-grafana
approved these changes
Feb 23, 2021
|
Good catch, "documentation" word was missing and it is needed here. |
|
I actually commented on the wrong PR, but I don't think this will work for both metrics and logs or there should be a documented caveat on that. Cloudwatch Metrics and Cloudwatch Logs both use different endpoints |
|
We ran into this problem as well but adding to different data sources still leads to an error and the data is not fetched. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested using
monitoring.us-east-2.amazonaws.comand it works fine. Info about api endpoints and why to use them can be found hereAll the other AWS data source plugins that we have, i.e IOT Sitewise, Timestream and X-Ray, already have support for specifying a custom endpoint.
Fixes #26041