Better combines stats in ingesters #9474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
owen-d
commented
May 17, 2023
owen-d
commented
- Reduces double counting streams when possible
- proportionally add stats based on chunk overlap range
- code reuse
…reams in instance stats + some code reuse Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
DylanGuedes
reviewed
May 17, 2023
| @@ -584,12 +584,17 @@ func (i *instance) GetStats(ctx context.Context, req *logproto.IndexStatsRequest | |||
| chkFrom, chkThrough := chk.chunk.Bounds() | |||
|
|
|||
| if !chk.flushed.Equal(zeroValueTime) && from.Before(chkThrough) && through.After(chkFrom) { | |||
There was a problem hiding this comment.
double checking: shouldn't here be from.Before(chkThrough) || through.After(chkFrom) as it is a partial overlap?
Ex:
edit: ok I suck at doing ascii art
// From ______ chkFrom____Through____chkThrough|
// │____________|_______ Chunk _____________│
There was a problem hiding this comment.
from.Before(chkThrough) && through.After(chkFrom) can only be true when there's some degree of overlap with the time range and chunk. In your ascii example that holds true. If we used || instead of &&, it would include potentially non-overlapping ranges.
salvacorts
approved these changes
May 18, 2023
slim-bean
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.