Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Count unflushed chunks in instance stats #9479

Merged
merged 1 commit into from
May 18, 2023
Merged

Count unflushed chunks in instance stats #9479

merged 1 commit into from
May 18, 2023

Conversation

MasslessParticle
Copy link
Contributor

The instance wasn't counting unflushed chunks in the stats. This change checks that the chunk's flushed time is 0 which means it hasn't been flushed yet.

owen-d
owen-d approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixes my old bug

@MasslessParticle MasslessParticle marked this pull request as ready for review May 18, 2023 21:42
@MasslessParticle MasslessParticle requested a review from a team as a code owner May 18, 2023 21:42
@MasslessParticle MasslessParticle merged commit aeba51a into main May 18, 2023
@MasslessParticle MasslessParticle deleted the tpatterson/fix-ingester-chunk-stats branch May 18, 2023 21:42
MasslessParticle added a commit that referenced this pull request May 23, 2023
@MasslessParticle
Revert "Count unflushed chunks in instance stats (#9479)"
2b1ed8e 
This reverts commit aeba51a.
@MasslessParticle MasslessParticle mentioned this pull request Jun 2, 2023
Merged
owen-d pushed a commit that referenced this pull request Jun 2, 2023
@MasslessParticle
Revert "revert count unflused chunks (#9504)" (#9615)
6d8a184 
Now that the bug where huge values is fixed and known not to be this.
Let's readd it.

Original: #9479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owen-d owen-d owen-d approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MasslessParticle @owen-d