Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update download URL for ocb #45

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

jpkrohling
Copy link
Collaborator

@jpkrohling jpkrohling commented Jan 26, 2023

ocb has its own tag now on the core repository, causing the download URL to change. This PR makes the Makefile use the new location.

When ocb is not on the path, the following happens:

> make generate-sources
Installing ocb (linux/amd64) at /home/jpkroehling/bin
Skipping the compilation, we'll only generate the sources.
Distributions to build: sidecar,tracing,otel-grafana
Building: sidecar
Using Builder: /home/jpkroehling/bin/ocb
Using Go: /usr/bin/go
❌ ERROR: failed to build the distribution 'sidecar'.
🪵 Build logs for 'sidecar'
----------------------
/home/jpkroehling/bin/ocb: line 1: Not: command not found
----------------------
make: *** [Makefile:24: generate-sources] Error 1

After this change:

> make generate-sources
Installing ocb (linux/amd64) at /home/jpkroehling/bin
Skipping the compilation, we'll only generate the sources.
Distributions to build: sidecar,tracing,otel-grafana
Building: sidecar
Using Builder: /home/jpkroehling/bin/ocb
Using Go: /usr/bin/go
✅ SUCCESS: distribution 'sidecar' built.
Building: tracing
Using Builder: /home/jpkroehling/bin/ocb
Using Go: /usr/bin/go
✅ SUCCESS: distribution 'tracing' built.
Building: otel-grafana
Using Builder: /home/jpkroehling/bin/ocb
Using Go: /usr/bin/go
✅ SUCCESS: distribution 'otel-grafana' built.

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling
Copy link
Collaborator Author

@rlankfo, would you like to review this one?

Copy link
Member

@rlankfo rlankfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpkrohling jpkrohling merged commit 599ead8 into main Jan 27, 2023
@jpkrohling jpkrohling deleted the jpkrohling/update-download-url-for-ocb branch January 27, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants