-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pagination for tag search endpoint #3599
Comments
pagination is difficult, but likely not impossible. i'd have to think on it some. we have recently added a streaming tags endpoint that might meet your needs. it can be exercised using the tempo-cli tool (or any appropriate grpc client): https://github.com/grafana/tempo/blob/main/cmd/tempo-cli/cmd-query-search-tag-values.go this will be released in 2.5. |
Hi @joe-elliott - sorry I think my initial comment might have been a bit misleading, as we aren't directly calling that API endpoint. The endpoint is being hit from the “Search” tab in the default Grafana Tempo plugin. So we are seeing 500's every time someone loads that page in “Explore” mode. Will the new streaming endpoint you mentioned be used in the Grafana Tempo plugin UI? |
The Grafana team is aware of this endpoint, but has no immediate plans to implement it. Since you are clearly showing interest do you want to create an issue on https://github.com/grafana/grafana/? I can +1 the issue and make sure it's tagged appropriately. |
Hello @joe-elliott , I was going to ask you if the multiplexed http/grpc issues with TraceQL streaming is resolved, but then I searched and saw your PR: #3300 Before I start playing around with our dev environment, did the above PR make it possible to multiplex http/grpc connections over an AWS ALB? |
I'm honestly not sure, but I don't see why not. You'd need to forward http2/http to the same port in Tempo. |
This issue has been automatically marked as stale because it has not had any activity in the past 60 days. |
We've been encountering an issue with 500 error responses when making requests to the
/api/v2/search/tag/name/values
endpoint. This is due to the response size exceeding the maximum configured value, as outlined in the Grafana documentation here: https://grafana.com/docs/tempo/latest/troubleshooting/search-tag/Although the documentation suggests reducing the cardinality of tags or increasing the
max_bytes_per_tag_values_query
parameter, we don't think these solutions are feasible in the long-run.We'd like to suggest pagination on this API endpoint, which will resolve the current issue and be a more scalable solution. It would also lead to better user experience as the data load times would be able to be reduced.
The text was updated successfully, but these errors were encountered: