-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend Refactor: Streaming tags #3460
Conversation
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Co-authored-by: Mario <mariorvinas@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Arguments: | ||
- `host-port` A host/port combination for Tempo. The scheme will be inferred based on the options provided. | ||
- `tag` The fully qualified traceql tag to search for. e.g. `resource.service.name` | ||
- `start` Start of the time range to search: (YYYY-MM-DDThh:mm:ss) | ||
- `end` End of the time range to search: (YYYY-MM-DDThh:mm:ss) | ||
|
||
Options: | ||
- `--org-id <value>` Organization ID (for use in multi-tenant setup). | ||
- `--use-grpc` Use GRPC streaming | ||
- `--path-prefix <value>` String to prefix search paths with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the kind of thing you might consider using a definition list, which is supported by Hugo. That the top item (the term) is bold, and the definition appears underneath.
Arguments: | |
- `host-port` A host/port combination for Tempo. The scheme will be inferred based on the options provided. | |
- `tag` The fully qualified traceql tag to search for. e.g. `resource.service.name` | |
- `start` Start of the time range to search: (YYYY-MM-DDThh:mm:ss) | |
- `end` End of the time range to search: (YYYY-MM-DDThh:mm:ss) | |
Options: | |
- `--org-id <value>` Organization ID (for use in multi-tenant setup). | |
- `--use-grpc` Use GRPC streaming | |
- `--path-prefix <value>` String to prefix search paths with | |
Arguments: | |
`host-port` | |
: A host/port combination for Tempo. The scheme will be inferred based on the options provided. | |
`tag` | |
: The fully qualified traceql tag to search for; for example: `resource.service.name` | |
`start` | |
: Start of the time range to search: (`YYYY-MM-DDThh:mm:ss`) | |
`end` | |
: End of the time range to search: (`YYYY-MM-DDThh:mm:ss`) | |
Options: | |
`--org-id <value>` | |
: Organization ID (for use in multi-tenant setup). | |
`--use-grpc` | |
: Use GRPC streaming | |
`--path-prefix <value>` | |
: String to prefix search paths with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea but there are a ton of commands in this file and if we go to definition lists then we should do all at once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the docs! I had a minor formatting suggestion.
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
* cancel context Signed-off-by: Joe Elliott <number101010@gmail.com> * update dskit Signed-off-by: Joe Elliott <number101010@gmail.com> * focused timeouts Signed-off-by: Joe Elliott <number101010@gmail.com> * docs Signed-off-by: Joe Elliott <number101010@gmail.com> * lint N docs Signed-off-by: Joe Elliott <number101010@gmail.com> * more lint Signed-off-by: Joe Elliott <number101010@gmail.com> * make update-mod Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com>
Bumps [anchore/sbom-action](https://github.com/anchore/sbom-action) from 0.15.8 to 0.15.9. - [Release notes](https://github.com/anchore/sbom-action/releases) - [Commits](anchore/sbom-action@v0.15.8...v0.15.9) --- updated-dependencies: - dependency-name: anchore/sbom-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* doc: remove reference to previously purged script * doc: correct label for docs updates
…ation check (grafana#3484) * Use new per-tenant max_metrics_duration, and fix duration timestamp handling * Update docs and defaults
* Handle prefixes when listing blocks from S3 fixes grafana#3465 * Handle prefixes when listing blocks from GCS * Add test for prefixes when listing blocks from Azure * Update unit tests to check for actual block IDs instead of just length of the slices Cleanup unit tests * Further refine S3/GCS backend for ListBlocks Brings logic more in line with Azure object parsing. Also has the benefit of handling prefixes without a trailing slash. * Update poller integration test to exercise prefixes * Update e2e test to exercise prefixes * Fix format check error * Fix failing e2e tests * Remove unnecessary prefix permutations from e2e test * Remove unnecessary test config file copy * Ignore lint --------- Co-authored-by: Zach Leslie <zach.leslie@grafana.com>
Updates the doc-validator to the latest version. Note that this changes the reference format to use the full URL (https://....) instead of /docs/blah
* [DOC] Document Tempo Operator Monolithic mode Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com> * clarify supported storages Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com> * fix case of title Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com> * Apply suggestions from code review * Apply suggestions from code review --------- Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com> Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
…ators (grafana#3473) * [docs] document Grafana data source setup using Grafana and Tempo operators * move the Grafana data source setup page to the operator folder (this page is only relevant for the operator) * document Grafana data source setup using Grafana and Tempo operators Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com> * Apply suggestions from code review --------- Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com> Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
…na#3455) * Bump github.com/prometheus/client_golang from 1.18.0 to 1.19.0 Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.18.0 to 1.19.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.18.0...v1.19.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update serverless gomod --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: grafanabot <bot@grafana.com>
…#3458) * Add support for dashes, quotes and spaces in attribute names * chlog
* Step align query_range time range * Time range error: improve message and fix format for prom format. * oops remove printlns * lint * changelog
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
What this PR does:
Moves all tags endpoints over to the new frontend async pipeline. Additionally adds:
Which issue(s) this PR fixes:
Work toward #3400
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]