Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi-tenant queries in streaming search #3262

Merged
merged 19 commits into from
Jan 25, 2024

Conversation

electron0zero
Copy link
Member

@electron0zero electron0zero commented Dec 26, 2023

What this PR does:

Add multi-tenant query support in streaming search endpoints.

follow up on #3087

Which issue(s) this PR fixes:
Fixes #1858

Tasks

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

integration/e2e/multi_tenant_test.go Outdated Show resolved Hide resolved
integration/e2e/multi_tenant_test.go Outdated Show resolved Hide resolved
integration/e2e/multi_tenant_test.go Outdated Show resolved Hide resolved
modules/frontend/search_streaming.go Outdated Show resolved Hide resolved
modules/frontend/search_streaming.go Outdated Show resolved Hide resolved
modules/frontend/search_streaming.go Outdated Show resolved Hide resolved
modules/frontend/search_streaming.go Outdated Show resolved Hide resolved
modules/frontend/search_streaming.go Show resolved Hide resolved
@electron0zero electron0zero force-pushed the mt_search_streaming branch 2 times, most recently from b3369af to 18ae136 Compare January 18, 2024 21:48
@knylander-grafana
Copy link
Contributor

@electron0zero What would you think about adding a query example to the TraceQL page to demonstrate this new capability? Are there any configuration options that need to be updated?

integration/e2e/multi_tenant_test.go Outdated Show resolved Hide resolved
modules/frontend/search_streaming.go Show resolved Hide resolved
modules/frontend/search_progress.go Outdated Show resolved Hide resolved
modules/frontend/search_streaming.go Outdated Show resolved Hide resolved
modules/frontend/search_streaming.go Outdated Show resolved Hide resolved
modules/frontend/search_streaming.go Outdated Show resolved Hide resolved
@electron0zero
Copy link
Member Author

@electron0zero What would you think about adding a query example to the TraceQL page to demonstrate this new capability?

@knylander-grafana It will be transperent to user querying data and should work for all queries, and doesn't add anything new in TraceQL.

Are there any configuration options that need to be updated?

this is a follow up on #3087, and we documented config option in that PR, no updates now.

Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go!

@electron0zero electron0zero merged commit 96c4e72 into grafana:main Jan 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Ability to search all tenants in multi-tenant setups
3 participants