deprecating vparquet v1 #3377
Merged
deprecating vparquet v1 #3377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ie-pham
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
kvrhdn,
zalegrala,
electron0zero and
stoewer
as code owners
joe-elliott
approved these changes
Feb 9, 2024
| @@ -32,14 +32,14 @@ You can still use the previous format `vParquet2`. | |||
| To enable it, set the block version option to `vParquet2` in the Storage section of the configuration file. | |||
There was a problem hiding this comment.
this is weird advice. we should likely not be advising anyone to set their version to vParquet2 at this point.
There was a problem hiding this comment.
Well, the full context was. Default = vParquet3. But "You can still use the previous format vParquet2."
tempodb/encoding/versioned.go
Outdated
| @@ -85,7 +85,7 @@ func LatestEncoding() VersionedEncoding { | |||
| func AllEncodings() []VersionedEncoding { | |||
| return []VersionedEncoding{ | |||
| v2.Encoding{}, | |||
| vparquet.Encoding{}, | |||
| // vparquet.Encoding{}, | |||
There was a problem hiding this comment.
this will help with tests. good call.
There was a problem hiding this comment.
can we remove it instead of commenting it out?
electron0zero
approved these changes
Feb 9, 2024
kvrhdn
pushed a commit
to kvrhdn/tempo
that referenced
this pull request
Feb 26, 2024
* deprecating vparquet v1 * update docs and tests * meow * remove line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: Deprecating vParquet v1. vParquet v1 blocks can still be read but write is no longer allowed.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]