Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 429s tripping SLOs #3469

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Fix 429s tripping SLOs #3469

merged 3 commits into from
Mar 6, 2024

Conversation

joe-elliott
Copy link
Member

@joe-elliott joe-elliott commented Mar 6, 2024

What this PR does

  • Correctly translates "queue full" into a 429 for the http pipeline
  • Correctly propagates ResourceExhausted gRPC error instead of InvalidArgument
  • Correctly prevents 429s from counting against SLOs

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Member

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott joe-elliott merged commit ae083c3 into grafana:main Mar 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants