-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow flushing blocks from the local-blocks processor [2 of 3] #3691
Conversation
if err != nil { | ||
_ = level.Error(p.logger).Log("msg", "failed to flush a block", "err", err) | ||
|
||
if op.attempts < 3 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's copy the behavior of the ingester, which doesn't limit retries on flushing to object storage. This will make it tolerate network or other transient errors as long as needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't allowing infinite retries dangerous?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! One more small nit but going ahead and approving.
What this PR does:
This PR adds the ability to the local-blocks processor to flush blocks to storage, with the objective of flushing blocks with a replication factor of 1 (see previous PR: #3628).
It adds the
store
module as a dependency of themetrics-generator
. The module is only instantiated when the storage is configured, working as before when it is not configured.Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]