Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v2.6] [TraceQL Metrics] Remove all obsolete settings and code for RF3 metrics #4010

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

joe-elliott
Copy link
Member

Backport 43d9326 from #3995


What this PR does:
Deletes all obsolete settings and code for metrics queries against RF3 blocks. This path didn't scale, so we pivoted in the last release to a read path using RF1 blocks flushed from the generators. These don't need deduping or complex job handling, and it scales really well. This is the long-term duration, and some of the RF3 path is already broken accidentally by other feature additions, so it's good to delete it now.

This introduces some breaking changes against main builds in the past few months. (There is no breaking change with v2.5, these are unreleased features changing pre-2.6)

  1. the rf1_read_path frontend setting is deleted. The read path is always rf1 now. This will cause a configuration parse error on startup if you have set this value. It must be removed.
  2. The local-blocks processor must be enabled to start using metrics queries like { } | rate(). If not enabled metrics queries fail with the error localblocks processor not found. Enabling the local-blocks processor can be done two ways:

(a) . Per-tenant in the per-tenant overrides:

overrides:
  'tenantID':
    metrics_generator_processors:
      - local-blocks

(b) or by default for all tenants in the main config:

overrides:
  defaults:
    metrics_generator:
      processors: [local-blocks] 
  1. The get metrics queries on historical data, you must configure the local-blocks processor to flush rf1 blocks to object storage:
metrics_generator:
  processor:
    local_blocks:
      flush_to_storage: true

Other changes:

  1. The query hints sample and job_interval are obsolete and were only parts of the RF3 sharding mechanism. These hints no longer do anything.

Which issue(s) this PR fixes:
Fixes n/a

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

…cs (#3995)

* Remove all obsolete settings and code for RF3 metrics. The only path going forward is RF1-based

* Remove remaining references to rf1_read_path

* changelog

* Remove another reference to obsolete sampling rate

* Update error messages for correctness

(cherry picked from commit 43d9326)
@joe-elliott joe-elliott merged commit 3e2a967 into release-v2.6 Aug 27, 2024
20 checks passed
@joe-elliott joe-elliott deleted the backport-3995-to-release-v2.6 branch August 27, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants