[DOC] Add other attributes to trace structure doc #4106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knylander-grafana
added
type/docs
knylander-grafana
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
kvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
| @@ -33,15 +33,20 @@ The first four properties are *intrinsics*. | |||
| They are fundamental to the span. | |||
|
|
|||
| *Attributes* are custom span metadata in the form of key-value pairs. | |||
| There are two types of attributes: **span attributes** and **resource attributes**. | |||
| There are four types of attributes: span attributes, resource attributes, event attributes, and link attributes. | |||
There was a problem hiding this comment.
@ie-pham Would you review this text for link and event?
|
This PR must be merged before a backport PR will be created. |
1 similar comment
|
This PR must be merged before a backport PR will be created. |
ie-pham
approved these changes
Sep 20, 2024
tempo-gh-bot bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
(cherry picked from commit 0172f4d)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Updates the trace structure doc to include all 4 attributes.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]