Skip to content

Commit

Permalink
Revert "Remove unnecessary test dependencies from build (#12390)"
Browse files Browse the repository at this point in the history
This reverts commit ca01dbe
  • Loading branch information
puneetbehl committed Mar 29, 2022
1 parent dab9c07 commit c826b52
Show file tree
Hide file tree
Showing 12 changed files with 9 additions and 17 deletions.
4 changes: 2 additions & 2 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -428,11 +428,11 @@ subprojects { project ->
sourceCompatibility = "1.8"
targetCompatibility = "1.8"

if(project.name =~ /^(grails-web|grails-plugin-|grails-test-suite)/) {
if(project.name =~ /^(grails-web|grails-plugin-|grails-test-suite|grails-test)/) {
dependencies {
api "javax.servlet:javax.servlet-api:$servletApiVersion"
// MockHttpServletRequest/Response/Context used in many classes
testImplementation("org.springframework:spring-test:${springVersion}") {
api("org.springframework:spring-test:${springVersion}") {
exclude group: 'commons-logging', module:'commons-logging'
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import grails.ui.support.DevelopmentWebApplicationContext
import grails.util.BuildSettings
import groovy.transform.CompileStatic
import groovy.transform.InheritConstructors
import org.springframework.mock.web.MockServletConfig
import org.springframework.mock.web.MockServletContext
import org.springframework.web.context.support.GenericWebApplicationContext

/*
Expand Down
2 changes: 1 addition & 1 deletion grails-core/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ dependencies {
exclude group: 'commons-logging', module:'commons-logging'
}

testImplementation("org.springframework:spring-test:${springVersion}") {
compileOnly("org.springframework:spring-test:${springVersion}") {
exclude group: 'commons-logging', module:'commons-logging'
}
compileOnly("org.codehaus.groovy:groovy-templates:$groovyVersion")
Expand Down
2 changes: 0 additions & 2 deletions grails-plugin-controllers/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ dependencies {
api("org.springframework.boot:spring-boot-autoconfigure:$springBootVersion")
runtimeOnly project(':grails-plugin-i18n')

testImplementation project(":grails-test")

testRuntimeOnly "jline:jline:$jlineVersion"
testRuntimeOnly "org.fusesource.jansi:jansi:$jansiVersion"
}
2 changes: 2 additions & 0 deletions grails-plugin-i18n/build.gradle
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
dependencies {
api project(":grails-web")

api "org.codehaus.groovy:groovy-ant:$groovyVersion"
}
2 changes: 0 additions & 2 deletions grails-plugin-interceptors/build.gradle
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
dependencies {
api project(":grails-plugin-controllers")
api project(":grails-plugin-url-mappings")

testImplementation project(":grails-test")
}
2 changes: 0 additions & 2 deletions grails-plugin-mimetypes/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,4 @@ dependencies {
compileOnly "io.micronaut:micronaut-runtime:$micronautVersion"

api project(":grails-web")

testImplementation project(":grails-test")
}
1 change: 1 addition & 0 deletions grails-plugin-url-mappings/build.gradle
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
dependencies {
api project(":grails-web"), project(":grails-plugin-controllers")
api "junit:junit:${junitVersion}"
}
5 changes: 1 addition & 4 deletions grails-test/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ dependencies {


api project(":grails-plugin-mimetypes")
api project(":grails-web")
api "org.grails.plugins:converters:$legacyConvertersVersion"

// command line requirements
Expand All @@ -23,8 +24,4 @@ dependencies {

// needed for Spock
api "org.objenesis:objenesis:${objenesisVersion}"

api("org.springframework:spring-test:${springVersion}") {
exclude group: 'commons-logging', module:'commons-logging'
}
}
2 changes: 0 additions & 2 deletions grails-web-common/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,4 @@ dependencies {
api "org.springframework:spring-webmvc:${springVersion}"
api "org.springframework:spring-context-support:${springVersion}"
implementation "com.github.ben-manes.caffeine:caffeine:$caffeineVersion"

testImplementation project(":grails-test")
}
2 changes: 0 additions & 2 deletions grails-web/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,4 @@ dependencies {
exclude group:'org.grails', module:'grails-encoder'
exclude group:'org.grails', module:'grails-web-common'
}

testImplementation project(":grails-test")
}

0 comments on commit c826b52

Please sign in to comment.