Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Add explicity type information to method parameters/args #13400

Merged
merged 1 commit into from
Feb 27, 2024
Merged

fix(core): Add explicity type information to method parameters/args #13400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion grails-shell/src/main/groovy/org/grails/cli/GrailsCli.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import groovy.transform.CompileStatic
import jline.UnixTerminal
import jline.console.UserInterruptException
import jline.console.completer.ArgumentCompleter
import jline.console.completer.Completer
import jline.internal.NonBlockingInputStream
import org.gradle.tooling.BuildActionExecuter
import org.gradle.tooling.BuildCancelledException
Expand Down Expand Up @@ -417,7 +418,7 @@ class GrailsCli {
new RegexCompletor("!\\w+"), new EscapingFileNameCompletor())
)

completers.addAll((profile.getCompleters(projectContext) ?: []) as Collection)
completers.addAll((profile.getCompleters(projectContext) ?: []) as Collection<Completer>)
consoleReader.addCompleter(aggregateCompleter)
return console
}
Expand Down
4 changes: 2 additions & 2 deletions grails-shell/src/main/groovy/org/grails/cli/profile/AbstractProfile.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,8 @@ abstract class AbstractProfile implements Profile {
}
}

defaultFeaturesNames.addAll(defaultFeatures)
requiredFeatureNames.addAll(requiredFeatures)
defaultFeaturesNames.addAll((List<String>) defaultFeatures)
requiredFeatureNames.addAll((List<String>) requiredFeatures)
}


Expand Down
2 changes: 1 addition & 1 deletion .../main/groovy/org/grails/web/databinding/converters/AbstractStructuredBindingEditor.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ abstract class AbstractStructuredBindingEditor<T> implements TypedStructuredBind
* @return A Map containing keys and values as described above.
*/
Map<String, Object> getPropertyValuesMap(String propertyPrefix, DataBindingSource bindingSource) {
def valuesMap = [:]
Map<String, Object> valuesMap = [:]
def prefix = propertyPrefix + '_'
for(String key : bindingSource.propertyNames) {
if(key.startsWith(prefix) && key.size() > prefix.size()) {
Expand Down
Loading