Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up exec and globals #1761

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Clean up exec and globals #1761

wants to merge 3 commits into from

Commits on Aug 26, 2024

  1. Remove unnecessary use of exec 

    Especially in the latter case of the `Verify` plugin, this exposed that
some methods were missing parameters.
    @QuLogic
    QuLogic committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    af613b8 View commit details
    Browse the repository at this point in the history

  2. Remove some usage of globals()

    @QuLogic
    QuLogic committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    908b908 View commit details
    Browse the repository at this point in the history

  3. Fix incorrect usage of exec 

    As of PEP558, `locals()` is not populated by `exec()`. This change means
that this call is broken on Python 3.13.
    @QuLogic
    QuLogic committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    f60f8dc View commit details
    Browse the repository at this point in the history