Feature/gcom 1120 | Improve defaultConfigurableOptionsSelection functionality #1991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ac6678d The changes in this PR will be included in the next version bump. This PR includes changesets to release 72 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JoshuaS98
changed the title
|
|
paales
requested changes
Jul 13, 2023
packages/magento-product-configurable/utils/defaultConfigurableOptionsSelection.ts
Outdated
Show resolved
Hide resolved
packages/magento-product-configurable/graphql/ConfigurableOptions.graphql
Outdated
Show resolved
Hide resolved
packages/magento-product-configurable/graphql/ConfiguredVariant.graphql
Outdated
Show resolved
Hide resolved
packages/magento-product-configurable/utils/defaultConfigurableOptionsSelection.ts
Outdated
Show resolved
Hide resolved
packages/magento-product-configurable/utils/defaultConfigurableOptionsSelection.ts
Outdated
Show resolved
Hide resolved
packages/magento-product-configurable/utils/defaultConfigurableOptionsSelection.ts
Outdated
Show resolved
Hide resolved
We currently never redirect a user and in the upcoming ConfigurableProductUrl PR only the URL is changed in the browser, but the page isn't actually reloaded. It is kinda odd if a user will receive multiple configurables for the simple URL. |
…eOptionsSelection.ts Co-authored-by: Paul Hachmang <paul@reachdigital.nl>
…eOptionsSelection.ts Co-authored-by: Paul Hachmang <paul@reachdigital.nl>
…t.graphql Co-authored-by: Paul Hachmang <paul@reachdigital.nl>
…ons.graphql Co-authored-by: Paul Hachmang <paul@reachdigital.nl>
|
|
|
JoshuaS98
commented
Jul 14, 2023
packages/magento-product-configurable/utils/defaultConfigurableOptionsSelection.ts
Outdated
Show resolved
Hide resolved
JoshuaS98
commented
Jul 14, 2023
packages/magento-product-configurable/utils/defaultConfigurableOptionsSelection.ts
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
1. Improve defaultConfigurableOptionsSelection functionality
Situation: You land on a simple product page.
In the current main branch, we check all the configurableOptions of the linked configurable item. If a simple product does not have this option as a property on it's product branch, the option can not be configured on the simple product page. To fix this, you had to query that option in your productPage query to make it a property on the simple product. This however meant that you had to add a property to your query every time a site owner made a new configurable option. This is not dynamic nor scalable.
To fix this:
We check the variants of a configurable option and match the variant SKU's with the SKU of the current simple product. When we know which variant should be preselected, we get the uid(s) from the variant's attribute(s) and inject them into the selectedOptions array.
2. Match the CORRECT related upsells with the CORRECT product
In the current main branch, the first item of the relatedUpsells array is being merged into the product object. But in case of a simple product, magento not only gives the simple product back, but also optional configurable products that are linked to it. Merging relatedUpsells[0] with the simple product will result in merging the wrong upsells with the simple product.
Test url
Please replace localhost for Vercel URL.
Simple product: localhost:3000/p/waverly-size-4-6y-gc-564-sock-6y
Concurrent configurable product: localhost:3000/p/gc-fruity-sock
Issues: