Fix bug when NullValue is nested inside ObjectValue #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dondonz
changed the title
dondonz
commented
Jan 22, 2023
| parsedValue = null; | ||
| } else { | ||
| parsedValue = parseLiteral(fld.getValue(), variables); | ||
| } | ||
| parsedValues.put(fld.getName(), parsedValue); |
There was a problem hiding this comment.
The overall Object value is guaranteed not to be NullValue as this is handled earlier in GraphQL Java, however it may contain a nested NullValue.
dondonz
commented
Jan 22, 2023
| @@ -54,7 +54,6 @@ public Object parseValue(Object input) throws CoercingParseValueException { | |||
| @Override | |||
| public Object parseLiteral(Object input) throws CoercingParseLiteralException { | |||
| // on purpose - object scalars can be null | |||
| //noinspection ConstantConditions | |||
There was a problem hiding this comment.
IDE said this is redundant
dondonz
commented
Jan 22, 2023
|
|
||
| mkObjectValue([ | ||
| field1: mkNullValue() | ||
| ] as Map<String, Value>) | [field1: null] // Nested NullValue inside ObjectValue |
There was a problem hiding this comment.
This test fails with the old behaviour, and passes with the new behaviour
andimarek
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90, thanks @Kingson-de for reporting!
Enables
NullValueto be nested insideObjectValue.