Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update to reference scalars.graphql.org specification for DateTime #93

Merged
merged 2 commits into from
Mar 12, 2023

Conversation

setchy
Copy link
Contributor

@setchy setchy commented Mar 11, 2023

Update to reference the https://scalars.graphql.org/ specification. 🤞 that more will come in time

Copy link
Member

@dondonz dondonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs!

We recently launched the GraphQL Scalars project and published a complete DateTime specification. The DateTime implementation in this library is compliant with this spec. Could you please update the link from the graphql-scalars.com URL to the new spec link? https://scalars.graphql.org/andimarek/date-time.html

FYI here's the blog post announcing the initiative https://graphql.org/blog/2023-01-14-graphql-scalars/ and the GraphQL Scalars home page https://scalars.graphql.org/

@setchy
Copy link
Contributor Author

setchy commented Mar 11, 2023

Ah, thanks @dondonz - I did read that blog article actually but just assumed (incorrectly) it was graphql-scalars.com. Thanks for the pointer.

@andimarek - side note - would it make sense to have a banner on graphql-scalars.com pointing people back to https://scalars.graphql.org/ etc?

@setchy setchy requested a review from dondonz March 11, 2023 23:24
@setchy setchy changed the title docs: update to reference graphql-scalars.com WIP specification for DateTime docs: update to reference scalars.graphql.org specification for DateTime Mar 12, 2023
Copy link
Member

@dondonz dondonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@dondonz dondonz merged commit 6a38e82 into graphql-java:master Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants