diff-npm-packages: fix crash with ENOBUFS (#3560)

graphql · May 6, 2022 · 2d1ec99 · 2d1ec99
1 parent 0978057
commit 2d1ec99
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/resources/diff-npm-package.js b/resources/diff-npm-package.js
@@ -3,7 +3,8 @@
 const os = require('os');
 const fs = require('fs');
 const path = require('path');
-const cp = require('child_process');
+
+const { exec } = require('./utils.js');
 
 const LOCAL = 'local';
 const localRepoDir = path.join(__dirname, '..');
@@ -93,12 +94,3 @@ function prepareNPMPackage(revision) {
   exec('npm --quiet run build:npm', { cwd: repoDir });
   return path.join(repoDir, 'npmDist');
 }
-
-function exec(command, options = {}) {
-  const result = cp.execSync(command, {
-    encoding: 'utf-8',
-    stdio: ['inherit', 'pipe', 'inherit'],
-    ...options,
-  });
-  return result?.trimEnd();
-}
diff --git a/resources/utils.js b/resources/utils.js
@@ -9,10 +9,11 @@ const prettier = require('prettier');
 function exec(command, options) {
   const output = childProcess.execSync(command, {
     maxBuffer: 10 * 1024 * 1024, // 10MB
+    stdio: ['inherit', 'pipe', 'inherit'],
     encoding: 'utf-8',
     ...options,
   });
-  return output && output.trimEnd();
+  return output?.trimEnd();
 }
 
 function readdirRecursive(dirPath, opts = {}) {