fix(validate): no reusing root types #3453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
thomasheyenbrock
force-pushed
the
fix/no-reusing-root-types
branch
from
1aa3ed7
to
19554e3
Compare
n1ru4l
reviewed
Jan 11, 2022
saihaj
approved these changes
May 8, 2022
yaacovCR
reviewed
May 9, 2022
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
thomasheyenbrock
force-pushed
the
fix/no-reusing-root-types
branch
from
d5ba504
to
1697d6b
Compare
yaacovCR
approved these changes
May 9, 2022
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
May 10, 2022
Extracted from graphql#3453 All credits goes to @thomasheyenbrock
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
May 10, 2022
Extracted from graphql#3453 All credits goes to @thomasheyenbrock
IvanGoncharov
added a commit
that referenced
this pull request
May 10, 2022
Extracted from #3453 All credits goes to @thomasheyenbrock
IvanGoncharov
force-pushed
the
fix/no-reusing-root-types
branch
from
1697d6b
to
095517a
Compare
|
@thomasheyenbrock Thanks for PR 👍 |
IvanGoncharov
added
the
PR: feature 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
graphql-jsfolks 👋 While playing with schema and SDL validation, I noticed that the reference implementation does not follow the following rule from the latest spec:Not sure if that's an error in the spec or in the reference implementation 🤔 I went ahead and proposed a fix in here, but happy to open a PR on the spec instead if that's the preferred. This is after all a breaking change, even though I doubt that it would have a big impact. (At least I've never seen a schema that does this.)