Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase tertiary/residential/unclassified casing strength #2448

Open
matthijsmelissen opened this issue Nov 19, 2016 · 6 comments
Open

Increase tertiary/residential/unclassified casing strength #2448

matthijsmelissen opened this issue Nov 19, 2016 · 6 comments

Comments

@matthijsmelissen
Copy link
Collaborator

White roads (tertiary/residential/unclassified) should contrast sufficiently with features like landcover and buildings, with which they are frequently surrounded. To increase the contrast, I think we need to make the casing of these roads darker.

I created some exaggerated examples for the sake of argument (final choice will probably be less strong).
screenshot_2016-11-19_13-14-58
screenshot_2016-11-19_13-14-14
screenshot from 2016-11-19 13 12 54
screenshot_2016-11-19_13-13-26

For those who would like to test with this, see the math1985/stronger-casing branch.

@pnorman
Copy link
Collaborator

pnorman commented Nov 19, 2016

1st, 2nd, and 3rd look reasonable, perhaps a touch too strong.
3 looks too strong for me.

@imagico
Copy link
Collaborator

imagico commented Nov 20, 2016

In my eyes this is too strong - at the moment the white roads' casing seems visually weaker than that of the colored roads. In you examples it looks stronger. The same strength (that would be somewhere in between) might be better.

@matthijsmelissen
Copy link
Collaborator Author

matthijsmelissen commented Nov 21, 2016

Thanks for the feedback! I submitted a more moderate version of this proposal as PR #2454.

In the PR, the colors are less strong than above across all levels, and in particular the lower ones. Also for service roads, the colors are not as dark.

@matthijsmelissen
Copy link
Collaborator Author

Something I wonder: is a 0.5 pixel wide black line equivalent to a 1 pixel wide gray line?

@imagico
Copy link
Collaborator

imagico commented Nov 21, 2016

Evidently not - especially on a black background 😄

What you probably want to know is if a 0.5 pixel black line looks like a 1 pixel black line with 50 percent opacity. Neither is this - although the difference is small and gets even smaller if you compare a 0.25 and a 0.5 pixel line.

@pnorman
Copy link
Collaborator

pnorman commented Nov 21, 2016

Something I wonder: is a 0.5 pixel wide black line equivalent to a 1 pixel wide gray line?

No - antialiasing will give them a different look, but they're close.

Until you go to a retina display, when they look quite different.

matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Mar 28, 2017
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Aug 12, 2017
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Nov 7, 2017
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants