Rendering of intermittent streams broken

[matthijsmelissen]

Rendering of intermittent streams seems broken in master.

Screen shot:

[matthijsmelissen]

Did something go wrong with the hstore merge perhaps?

[imagico]

I don't think this is due to the hstore changes, i think this is caused by 970df74, specifically

https://github.com/gravitystorm/openstreetmap-carto/blame/master/water.mss#L195-L197

Side note: the water-lines code is quite difficult to understand meanwhile with all the tunnel/background/bridge stuff mixed fairly wildly.

[pnorman]

Does this also impact 3.3.0?

[pnorman]

I don't think this is due to the hstore changes, i think this is caused by 970df74, specifically

https://github.com/gravitystorm/openstreetmap-carto/blame/master/water.mss#L195-L197

Yes, that looks like an error. some background/line-* properties are set, while background/line-color is unset except when int_tunnel = yes

[nebulon42]

Well spotted. This was somehow an leftover I have missed. This also impacts 3.3.0. I will cherry pick the commit to the 3.x branch once committed. As I have seen that 3.3.0 is now live we should probably release 3.3.1.

[boothym]

I noticed something similar with a large black line on the map - is it related to this issue? https://www.openstreetmap.org/way/4301350 ok on z18/19 though

[andischan]

Have you stopped the z=12 rerendering because of this?

[nebulon42]

@boothym Thanks for reporting this. It is now also fixed in #2636.
@andischan I'm not aware of anybody of us getting in touch with the sysadmins about this regression. So might be a tile server load or cache issue.

[Robot8A]

It also happens in channel bridges: https://www.openstreetmap.org/#map=17/41.62288/-0.90528

[nebulon42]

@Robot8A thanks, this was also fixed.

[andrewharvey]

Not sure if you're aware but this is still visible/an issue on osm.org, see the black lines which are intermittent streams:

https://www.openstreetmap.org/#map=13/-31.5630/159.0870

[imagico]

You have old tiles here - either browser cache or server side caching.

[andrewharvey]

You have old tiles here - either browser cache or server side caching.

No worries, I'll let it sort itself out over time then.

[naoliv]

New way https://www.openstreetmap.org/way/501481012 and it's still being rendered black: https://www.openstreetmap.org/#map=17/-28.96073/-52.65422

It can't be a cache issue with new data.

[HolgerJeromin]

The fixed version of the style has not yet been rolled out. Just look when openstreetmap/chef#124 is closed.