Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider unifying transport with air-transport and separating accommodation #3631

Open
jeisenbe opened this issue Jan 10, 2019 · 22 comments
Open

Comments

@jeisenbe
Copy link
Collaborator

Current situation:

  • Accommodation icons (such as hotels and campsites) use the same blue icon color as transportation icons (such as bus stops, taxis, and parking lots): #0092da
  • However, airports, helipads and ferry terminals have a violet color, #8461C4
  • There are currently 4 or 5 shades of blue used for icons

The current code already has a color @accommodation-icon but this is set to be the same as @transportation-icon currently:

@transportation-icon: #0092da;
@transportation-text: #0066ff;
@accommodation-icon: @transportation-icon;
@accommodation-text: @transportation-text;
@airtransport: #8461C4; //also ferry_terminal

Options:

1 Use #8461C4 (violet) for airtransport, transportation, and accommodations
air-transport-for-transport-accomodation-tests

  • @imagico has shown this option on his alt-colors fork, I believe.
  • This reduces the number of shades of blue used for icons (currently 4 or 5, if springs count)
  1. Use #8461C4 (violet) for both airtransport and transportation-icon, while continuing to use #0092da (blue) for accommodation-icon
    accommodation-blue-all-transport-purple-test
  • This is fairly logical; all transportation-related features use the same color
  • But this does not address the problem of using too many shades of blue.
  1. #8461C4 (violet) for airtransport and transportation, new color for accommodations
    accomodation-a1395a-test
  • For example, #a1395a Lch(40,45,5)
  • This color is similar to @tourism, but lighter and the hue is shifted slightly, to be less similar to @shop #ac39ac and @health #BF0000
@jeisenbe
Copy link
Collaborator Author

Here are some additional renderings with backgrounds:

  1. #8461C4 violet - for all
    air-transport-for-transport-accomodation-background

  2. #8461C4 violet for all transportation, #0092da blue for accommodation
    accommodation-blue-all-transport-purple-backgrounds

  3. #8461C4 violet for transportation, #a1395a for accommodation
    accomodation-a1395a-backgrounds

@kocio-pl
Copy link
Collaborator

For a bus station icon to change color you need to edit SVG code directly, probably in this line:

style="fill-opacity:1;stroke:none;stroke-width:0.0826974;fill:#0092da"

@Tomasz-W
Copy link

I don't see any problems with current rendering accomodation objects in transportation-blue, I consider proposed change as the one which would produce more problems instead of resolving any one.

@jragusa
Copy link
Contributor

jragusa commented Jan 10, 2019

This issue also raises (again ?) the debate about unification in transport amenities between highway=bus_stop, railway=tram_stop/station (#1127) and amenity=ferry_terminal. I think it will fix some blue icons.

@meased
Copy link
Contributor

meased commented Jan 10, 2019

I like options 1 and 2.

Perhaps we could also discuss merging airtransport and transportation colors?

@polarbearing
Copy link
Contributor

#3582 changed tourism outlines to #660033, can we take that into the comparisons? I'd consider it (at least the hue) as a candidate for accommodation as well.

@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Jan 11, 2019

I'd considered #660033 as well, but didn't include it as an option because it is much darker than the other icons. #a1395a is the result of my attempt to modify @tourism to work as an icon color.

#660033 is Lch(20,45,359)
#a1395a is Lch(40,45,5) - so same chroma, very slightly shifted hue, mainly lighter.

But I did already make test images with #660033 for accommodation-icon, here you go:
tourism-color-icons-test

tourism-color-icons-backgrounds

@kocio-pl
Copy link
Collaborator

I have difficulty saying if this is violet icon or brown. The only rescue are labels, which are different enough.

@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Jan 11, 2019

@jragusa mentioned that railway=tram_stop/station uses yet another shade of blue: @station-color: #7981b0

@Adamant36
Copy link
Contributor

Adamant36 commented Jan 11, 2019

Things like motels that aren't transportation related per say could probably change to a different color. Things like bike parking and the parking symbol are better in blue though. Blue for transport is intuitive and a widely used color for those things. imagico's alternative color scheme just looks horrible.

Even if blue is also used for water, I don't see why that would be an issue. Its widely different contexts and Know one is going to confuse a bus stop for a lake.

Its worth consolidating the different shades of blue so there aren't so many, but that's about the only thing that's worth doing. Ultimately, I don't see a benefit to changing the color of transportation itself. Also, making hotels any shade of purple like in the last example puts them to close in color to things like bakeries. Which is just weird (although I notice bikes are the same color as bakeries for some reason). Maybe hotels could be changed to amenity brown (as its a service or something, I guess? Hotels aren't strictly related to transportation or tourism though is my point). Along with camp sites.

Or campsites/alpine huts/caravan sites/whatever could be in man_made grey to fit shelters (or amenity brown along with hotels etc).

As a side note, it looks as if fountain is in its own kind of blue shade maybe?

(also related to #3395. I don't think blue can be resolved without taking a holistic approach)

@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Jan 11, 2019

it looks as if fountain is in its own kind of blue shade maybe

Yes, there are 6 blue colors used for icons currently. 2 are transportation-related, 3 are water-related.

  1. transportation-icon: #0092da
  2. office: #4863A0 - used for the office dots
  3. station-color: #7981b0 - used for train stations and tram stops
  4. marina-text: #576ddf - used for the fountain icon
  5. water-text: #4d80b3 - used for the waterfall icon
  6. The spring.svg file uses #7abcec

@polarbearing
Copy link
Contributor

Hotels aren't strictly related to ... tourism ... Along with camp sites.

No? I'd see those accommodations (hotel, motel, hostel, camp, huts) as the core of tourism.

I agree that #660033 is a bit to close to amenity-brown, but #a1395a is too close to shop for me.

@jeisenbe
Copy link
Collaborator Author

Another option is to keep #0092da for transportation and air-transport. This would change airports, heliports and ferry terminals to #0092da.
Accommodation could then use #8461C4 (or another color.)

Option 4: #0092da for transportation and air-transport, #8461C4 for accommodation
test-0092da-transportation-8461c4-accommodation

background-0092da-transportation-8461c4-accommodation

@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Jan 12, 2019

I agree that #660033 is a bit to close to amenity-brown, but #a1395a is too close to shop for me.

I've tried adjusting the color a bit more. This new color was based off of the old health color, adjusted to be less similar to new heath and shop: #ca4871 Lch(50,55,5)

Option 5: #ca4871 pink for accommodation, #8461C4 violet for transportation:
8461c4-transportation-ca4871-accommodation

8461c4-transportation-ca4871-accommodation-background

@Adamant36
Copy link
Contributor

@polarbearing > No? I'd see those accommodations (hotel, motel, hostel, camp, huts) as the core of tourism.

To me it depends. Hotels are used for a lot of reasons. Sometimes to visit family or go to a convention. They are also used by homeless people and for less savory purposes. I use to know someone who the manager of a pretty popular, although seeder, hotel and when the an ordnance passed banning people with local IDs from renting hotels to drive out the druggies they lost most of their business.

I guess it depends on your definition of tourism though. Id say hotels are at least elastic enough to be considered in another category, if it allows for the color to be changed. I wouldn't necessarily go beyond that though.

@polarbearing
Copy link
Contributor

Accommodation using previous airport #8461C4 seems good.

The following test, #ca4871, goes too close to health.

@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Jan 14, 2019 via email

@polarbearing
Copy link
Contributor

Which post? The string '0db3170' appears the first time in this thread.

@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Jan 15, 2019

Which post? The string '0db3170' appears the first time in this thread

Sorry, I meant "Option 3. in the first and second posts: #a1395a Lch(40,45,5)

@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Jan 15, 2019

For comparison, here is:
Option 6: #db3170 Lch(50,68,5) on accommodation icons. It's more saturated that the other new options above.
8461c4-transportation-0db3170-accommodation

8461c4-transportation-0db3170-accommodation-backgrounds

@jeisenbe
Copy link
Collaborator Author

There is a large gap in hues of icons between blue and green currently, so it would be possible to create a new aquamarine / green-blue color such as #07a1a3 (Lch60,35,138), for accommodation, transportation or another feature (craft?):

Option 7: #07a1a3 (Lch60,35,198) aqua:

8461c4-transportation-07a1a3-accommodation

8461c4-transportation-07a1a3-accommodation-background

@jeisenbe
Copy link
Collaborator Author

I've opened issue #3641 to discuss the wider issue of picking new colors and improving the current range of colors for icons. There I've also suggested a third new color #979506 in addition to the options above - but this would be better for landform-color than for transportation or accommodation icons.

@imagico imagico mentioned this issue Nov 10, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants