Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change boundary nature reserve / national park areas #1077

Conversation

matthijsmelissen
Copy link
Collaborator

Render nature reserve / national park areas with a double uninterruped line,
like marinas are currently rendered.

@matthijsmelissen matthijsmelissen changed the title Nature reserve border Change boundary nature reserve / national park areas Oct 18, 2014
@matthijsmelissen
Copy link
Collaborator Author

Before:
before

After:
after

Render nature reserve / national park areas with a double uninterruped line,
like marinas are currently rendered.

* Resolves gravitystorm#69
* Resolves gravitystorm#563
@mboeringa
Copy link

I think it looks like an improvement, just not entirely sure with very small nature reserves though (of which for example the Netherlands has many)... Maybe a slightly less broad border could still achieve the desired result, while not clogging up the entire area for smaller features?

By the way, is it just a visual deception that the area inside of the reserve appears lighter than in the "before" image?, or do you lighten up the inside somewhat?

@matthijsmelissen
Copy link
Collaborator Author

I think it looks like an improvement, just not entirely sure with very small nature reserves though (of which for example the Netherlands has many)... Maybe a slightly less broad border could still achieve the desired result, while not clogging up the entire area for smaller features?

I require minimally 100 pixels before the boundary gets rendered. Do you think that's sufficient?

By the way, is it just a visual deception that the area inside of the reserve appears lighter than in the "before" image?, or do you lighten up the inside somewhat?

Must be an optical illusion.

@mboeringa
Copy link

I require minimally 100 pixels before the boundary gets rendered. Do you think that's sufficient?

OK, so this border doesn't get rendered on features if they are less than 100px across rendered? This means the old type of border is visible for smaller features? The 100px doesn't sound bad though, as threshold.

@matthijsmelissen
Copy link
Collaborator Author

This means the old type of border is visible for smaller features?

Not at the moment, do you think rendering such small nature reserves is useful?

@mboeringa
Copy link

Not at the moment, do you think rendering such small nature reserves is useful?

Well, I know there are what among Dutch biologists is called "postage-stamp" size nature reserves , sometimes not more than a single wet meadow field with clean groundwater influence and rare species, among more intensively used farmland.

Whether they deserve rendering is a bit arbitrary, but their botanic value can be high, even though small.

But I can't really answer that question, something for the tagging mailing list?

@matthijsmelissen
Copy link
Collaborator Author

I measure the minimum size in pixels, so as long a you zoom in enough, they should show up... Note that 100 pixels surface means an area of 10x10 pixels.

@pnorman
Copy link
Collaborator

pnorman commented Oct 19, 2014

I think we should be rendering them. Obviously not a name, but the boundary/fill.

@dieterdreist
Copy link

2014-10-19 21:40 GMT+02:00 Paul Norman notifications@github.com:

I think we should be rendering them. Obviously not a name, but the
boundary/fill.

I'd also render them, also with name, but zoom level and size-dependent. As
it was recently rejected to render the boundary=protected_area, we will not
have significance distinction besides "national" level and "reserve", so
we'll have to stick to size alone. For small patches of protected areas,
rendering a name could start as late as zoom 18.

@matthijsmelissen
Copy link
Collaborator Author

This PR does not change anything about name rendering. Names are already rendered depending on zoom level.

@matkoniecz
Copy link
Contributor

As it was recently rejected to render the boundary=protected_area

#603 is not rejected

@matthijsmelissen
Copy link
Collaborator Author

Re-assigned to self to take comments into account.

@imagico
Copy link
Collaborator

imagico commented Oct 30, 2014

Given the wide range of sizes of these areas it might be a good idea to make the upper zoom level limit of showing the semitransparent fill depend on size. There are quite a few nature reserves that have screen filling size already at much below z=13 and the fill can be very irritating then by distorting other colors.

matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this pull request Dec 8, 2014
This changes the rendering of national parks in the following way:
* Render border with a double uninterrupted line (line marinas).
* Require 100px minimum size for rendering.
* For zoom levels 10-12, drop transparent fill.

* Resolves gravitystorm#69
* Resolves gravitystorm#563
* Supersedes gravitystorm#1077

Changes with respect to gravitystorm#1077:
* Restore transparent fill for zoomlevels 7-9.
* Make line slightly narrower on zoomlevels 10-12 and wider on zoomlevel 10-13.
@matthijsmelissen
Copy link
Collaborator Author

Superseded by #1147.

@matthijsmelissen
Copy link
Collaborator Author

just not entirely sure with very small nature reserves though (of which for example the Netherlands has many)..

I don't think we should render 'post stamp' nature reserves on high zoom levels. I don't think < 100px nature reserves are relevant on any zoom level. If you zoom in, they will show up automatically.

@matthijsmelissen
Copy link
Collaborator Author

Given the wide range of sizes of these areas it might be a good idea to make the upper zoom level limit of showing the semitransparent fill depend on size.

I agree, in #1147, which supersedes this issue, the semitransparent fill is not rendered on z10 and above.

@gravitystorm
Copy link
Owner

superceeded by #1147

@matthijsmelissen matthijsmelissen deleted the nature-reserve-border branch January 7, 2015 01:56
@matthijsmelissen matthijsmelissen restored the nature-reserve-border branch January 8, 2015 15:29
@matthijsmelissen matthijsmelissen deleted the nature-reserve-border branch January 8, 2015 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nature reserve extents are unclear national_park on top of a road looks like an access restriction
7 participants