Render glaciers and icesheets from z8 instead of z6 #2970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't render other landcover at z6/z7, and the glaciers, especially in the Alps, currently attract too much attention.
|
Current rendering of the Alps: |
|
As I said - it makes sense if we don't plan to render natural features on z5+ soon. Otherwise it would be vanishing now and returning back: |
|
I'd prefer to make it consistent now, and I'm fine with reintroducing glaciers when/if we start rendering other landuse. |
Closed
|
OK, I agree and I tested that the code really works. Tajikistan z6 After z7 After |
|
sent from a phone
On 9. Dec 2017, at 14:40, Matthijs Melissen ***@***.***> wrote:
I'd prefer to make it consistent now, and I'm fine with reintroducing glaciers when/if we start rendering other landuse.
what about liquid water, shouldn’t it be removed then as well until z8 for consistency reasons?
|
|
Which kind of water would you like to filter out? I guess it's a special natural type to show general land/water difference. |
|
@dieterdreist - nice try. Or as i would put it - global warming has reached OSM... In case anyone is interested in the numbers - the approximate global statistics:
The last two of course depend highly on the definitions used. |
sommerluk
pushed a commit
to sommerluk/openstreetmap-carto
that referenced
this pull request
Dec 28, 2017
Changes caused by merging gravitystorm#2951 and gravitystorm#2970
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't render other landcover at z6/z7, and the glaciers, especially in
the Alps, currently attract too much attention.