Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding rendering for big natural=bay #3144

Merged
merged 1 commit into from
Mar 26, 2018
Merged

Conversation

kocio-pl
Copy link
Collaborator

@kocio-pl kocio-pl commented Mar 24, 2018

Rendering big bay labels is currently missing, notable example is Port Phillip Bay in Australia:

Using Mapnik 3.0.15 (currently in Kosmtik):

z8
rik1uo8i

z9 (probably eclipsed by a town name)
p3rcx_d4

Mapnik 3.0.19 (latest release):

z8
cdc4iu6v

z9
hxf tbsq

Related to #2068.

@geozeisig
Copy link

Render the label for ocean and sea in the same way as bay in blue letters. For ocean the tag place=ocean is used and for a large sea place=sea. There are not many of them, of course, but it's still important to show them. You could show them from Z4. Most of these objects are mapped as nodes, but we could change that so that they become areas. An example for testing would be Black Sea.

@kocio-pl
Copy link
Collaborator Author

I prefer to not go too fast. Technically it's easy, but each type of water might have some special problems (including node/area and multiple languages in name - Baltic would have 8). Bays are good for testing for some time in my opinion: some of them are similar to lake, some other are like named part of the sea, so it's good to review it after some time and learn from it.

@HolgerJeromin
Copy link
Contributor

ocean and sea is discussed in #2278
See especially this comment #2278 (comment)

@jeisenbe
Copy link
Collaborator

I’d like to note that this PR was merged only 2 days after it was opened, with no time for comments, and while it was technicallly approved by @matthijsmelissen there was no discussion of the impact on mappers by encouraging mapping of huge, non-verfiable bay polygons in cases like Hudson Bay or the Bay of Biscay.

Based on our consens-based decision making process, this PR should not have been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants