playground=sandpit with sand as background-color #3230
Conversation
A sandpit is always made of sand and therefore can and should be displayed as sand. However, in contrast to the general sand rendering, the playground should only be rendered in higher zoom levels since the size of the sandpit is most likely small and will only clutter the map when zoomed out. Details about at `playground=sandpit` at https://wiki.openstreetmap.org/wiki/Key:playground#playground-values Details about the tag usage https://taginfo.openstreetmap.org/tags/playground=sandpit
|
Hi! Did you try to install Docker-based testing environment?: https://github.com/gravitystorm/openstreetmap-carto/blob/master/DOCKER.md |
|
With no changes to the MML I don't believe this PR will work when you test it. |
|
playground =* tags playground equipment. We decided in #3161 not to render them. The sandpit is already rendered in sand-yellow when natural=sand is added. |
|
@polarbearing thanks for the hint with I know about PR #3161: The way read the discussion is, that special icons for where disliked, especially because they where confusing to read with the general playground icon in the middle. So IMO this PR has nothing to do with that. |
|
Yes, I also think that this is a special case worth adding. We want a semantic database and avoid adding |
|
I updated the PR Description with the "after" shots based on my testing of Only >=18Based on the screesnhots I think: Lets only show the sandpit for >= 18. Otherwise very small sandpits just clutter the map. About the codeCan anyone who knows how this works take over? It will take me a long while to setup a dev-env. I might have to migrate it into an regular issue. Here are some more screenshots of different zoom levelsZoom 19
Zoom 18
Zoom 17
Zoom 16
Zoom 15
|
Sounds good for me.
There's no hurry and I prefer that more people can use our toolset and produce proper code. We have too many issues and ideas, and too few regular coders. Do you have some problem with Docker containers? |
|
The sand in the pit is natural. There is no artificial sand, so natural=sand is not tagging for the renderer, it is the actual fact. |
|
sent from a phone
On 14. May 2018, at 08:54, polarbearing ***@***.***> wrote:
The sand in the pit is natural. There is no artificial sand, so natural=sand is not tagging for the renderer, it is the actual fact.
IMHO the key natural is for natural features, not for things made from natural material. A wooden house would not be natural=house. landcover=sand would not have this problem.
|
|
sent from a phone
On 12. May 2018, at 08:37, Tobias ***@***.***> wrote:
However, in contrast to the general sand rendering, the playground should only be rendered in higher zoom levels since the size of the sandpit is most likely small and will only clutter the map when zoomed out.
why not making the zoom level depending on the area size in pixels? While many sandpits are small, a huge one will appear odd when rendered only on very high zooms
|
We don't generally select fills based on area except for performance reasons at sizes that are hard to see. I'm not convinced that rendering a playground feature the same as natural=sand is a good idea. Our natural=sand rendering is designed to fit in with other nature features in the style, and a playground pit serves quite different purposes, even if it has the same material. It may also look the same from above, but we're not painting an aerial image, we're drawing a map. This is unrelated to the reason I'm closing this issue, which is that the author hasn't been able to test it or get it working, and doesn't know when they'll be able to do so. |
|
sent from a phone
On 17. May 2018, at 22:24, Paul Norman ***@***.***> wrote:
I'm not convinced that rendering a playground feature the same as natural=sand is a good idea. Our natural=sand rendering is designed to fit in with other nature features in the style
on the other hand you (not you as Paul Norman, but the osm carto team) suggested not too long ago natural=water for the water covered parts of fountains.
natural=sand is used as landcover=sand, it might indicate a natural feature, but not even sure it is the majority, the common property is that there is sand on the surface. If we go by meaning of tags according to usage, there’s a lost battle wrt natural, IMHO. (even worse natural=mud)
|
Changes proposed in this pull request:
A sandpit is always made of sand and therefore can and should be displayed with the color of sand. However, in contrast to the general sand rendering, the playground should only be rendered in higher zoom levels since the size of the sandpit is most likely small and will only clutter the map when zoomed out.
playground=sandpitat https://wiki.openstreetmap.org/wiki/Key:playground#playground-valuesTestcase 1 Karl-Marx-Platz
https://www.openstreetmap.org/#map=19/52.47447/13.44328
Before
After
Testcase 2 Kirchgasse
https://www.openstreetmap.org/#map=19/52.47799/13.44190
Before
After