Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icon for artwork_type=bust #3576

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Change icon for artwork_type=bust #3576

merged 1 commit into from
Dec 20, 2018

Conversation

jragusa
Copy link
Contributor

@jragusa jragusa commented Dec 17, 2018

Related to #3565

Changes proposed in this pull request:
Use bust.svg icon for artwork_type=bust instead of generic artwork icon

Test rendering with links to the example places:
https://www.openstreetmap.org/node/3156678281
The upper right one is artwork_type=sculpture

Before
bust_before

After
bust_after

@Adamant36
Copy link
Contributor

Although I'm generally in support of this, it only has 790 uses. Which is something to consider. Also, what's the diff between this and memorial=bust? The wiki isn't clear on it and I can't imagine a bust that's not a memorial. Otherwise, what would be the point in it? So the tag might be redundant. The example you provided is for the philosopher Jean-Jacques Rousseau. Am I correct to assume that its a memorial bust then? If so, it might be miss-tagging.

@kocio-pl
Copy link
Collaborator

It is sometimes much more clear if you have a statue or bust than if that is the artwork or memorial, so this is nice change.

@jragusa
Copy link
Contributor Author

jragusa commented Dec 17, 2018

Yes there is only 790 occurrences of artwork_type=bust, but we have also more than 3000 uses of memorial=bust. Since icon is already use for the latter, It's not like adding a new icon and it contributes to grow the use of this icon to about 4000 features.

IMO, the difference between artwork and memorial is like between decorative and commemorative. And, yes, memorial tag is probably more suitable in the above example.

@Adamant36
Copy link
Contributor

@jragusa, I agree. I was just wondering. I don't really see many decorative busts around. Not that I see that many commemorative ones either though I guess. I'd imagine most decorative ones would be in places like art galleries and most memorial ones would be in public spaces. That's about it as to my knowledge of these things (and its probably wrong), but I thought id ask. I still think its a good addition whatever the case.

@kocio-pl kocio-pl merged commit 29d7fe8 into gravitystorm:master Dec 20, 2018
@kocio-pl
Copy link
Collaborator

Thanks, it works as expected in my tests.

@jragusa jragusa deleted the bust branch December 31, 2018 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants