-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce way_pixels limit to >750 for protected_area boundaries #3661
Conversation
Renders green national_park, nature_reserve and protected area boundaries, and brown aboriginal_lands boundaries, at >750 waypixels instead of >3000. This causes the boundary outline to render 1 zoom level sooner than the name label for these areas, which normally renders at >3000 waypixels. This is also the same limit that is used for tourism areas, such as zoos and amusement parks, with outlines. Military areas render with > 900 waypixels.
This would partly revert #2119, but that should not be a big problem:
|
Seattle example: Old rendering from #2119 (comment) Current rendering Proposed rendering - the missing pieces inside are now back, while borders are no longer screaming |
Warsaw example: Old from #2119 (comment) Current Proposed |
Thanks for the additional test renderings! I
hope this is a good compromise.
…On Tue, Feb 5, 2019 at 1:13 PM kocio-pl ***@***.***> wrote:
Warsaw example:
Old from #2119 (comment)
<#2119 (comment)>
[image: aq2tiysm]
<https://user-images.githubusercontent.com/5439713/33798107-4d93379a-dd13-11e7-84b4-396f25392785.png>
Current
[image: screenshot_2019-02-05 openstreetmap carto kosmtik 2]
<https://user-images.githubusercontent.com/5439713/52252706-440fb980-2904-11e9-90a7-26e6ea27b1a8.png>
Proposed
[image: screenshot_2019-02-05 openstreetmap carto kosmtik 3]
<https://user-images.githubusercontent.com/5439713/52252708-470aaa00-2904-11e9-89f3-3b83c4bee049.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3661 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshOjgLE957lLyopsQT-A_rX-Z_SGpks5vKQTRgaJpZM4aaK6A>
.
|
Syracuse example: Old from #2119 (comment) Current Proposed |
Both US examples are extreme and they still look sane now, so yes, I think so. Thanks for making and explaining this unification. |
It looks like the issue in those areas is that there are some moderately large protected_areas (wilderness or state forest?) which have many small outlying parcels, so it looks odd when these suddenly appear. If they were separate protected areas, they would not be render for another 2 or 3 zoom levels. Since the way_area is based on the whole multi-polygon, we can't easily render the outline for only the largest polygon without also rendering the tiny outlying polygons. For text labels, there's a property We could ask the Mapnik developers if they could consider adding a similar feature for polygon fills and outlines? |
Sure, please do. |
Changes proposed in this pull request:
Explanation
Test rendering with links to the example places:
Lake Gilles, South Australia
https://www.openstreetmap.org/#map=9/-33.0317/136.9267
Before: z8
z9
After: z8
z9
Singapore
https://www.openstreetmap.org/#map=13/1.3804/103.8138
z12 Before
z12 After
Sungei Buloh
z13 Before
After: z13
z14 same
Chestnut Nature Park (left)
z13 Before
After z13
z14 same