Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pitch color to be less blue #4480

Merged
merged 2 commits into from
Oct 29, 2023

Conversation

jgruca
Copy link
Contributor

@jgruca jgruca commented Sep 30, 2021

Fixes #4479

Change proposed in this pull request:

  • Update @pitch from #aae0cb to #88e0be

Test rendering with links to the example places:

Golf course with water hazards
https://www.openstreetmap.org/#map=15/41.5966/-93.6898

z15
1-z15
z16
1-z16
z17
1-z17

Park with pitches and pool
https://www.openstreetmap.org/#map=15/41.5731/-93.7213

z15
2-z15
z16
2-z16
z17
2-z17

School with pitches and sports center, nearby wooded area
https://www.openstreetmap.org/#map=15/41.5982/-93.7211

z15
3-z15
z16
3-z16
z17
3-z17

Comparison with the rest of the colors in this style
comparison

@imagico
Copy link
Collaborator

imagico commented Oct 1, 2021

I will not oppose this change if it finds support by other maintainers but i would strongly advise against it because it would go against almost every concept of systematic color design we have followed or considered in the past.

The logical alternative would be to roll back #2363 (and it might be helpful to read up the discussion that led to that choice in #2071 - which contains some of the considerations regarding systematic color choices i consider important). You could also have a look at the ac-style which uses #88e0be - although that is designed to work together with other changes, in particular a distinct color for playgrounds.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Oct 1, 2021 via email

@Adamant36
Copy link
Contributor

Any change in pitch color is going to have to account the color of the landuse below it and IMO this color makes the current color for parks stand out way to much. Especially at z17.

Copy link
Collaborator

@jeisenbe jeisenbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not have 2 colors that are only barely visually different. In the unusually case with a pitch and allotments overlapping or adjacent it will be hard to see the difference. The differnence between the new pitch and current allotments is only Δ: 4.3 in Lch, which is not enough to be clearly understood.

However, we cannot simply unifiy the color with that of allotments. Similar colors should have similar meanings. Allotments are not very similar to sports tracks or pitches.

Alternatives that could be accepted would be to pick a different new color for pitches which was not too similar to another color. As mentioned above, #88e0be might work. I would also suggest looking at #b8dabd.

Another option would be to change the allotments colors. These are similar to farmland and gardens, but also sometimes related to residential areas. I could be challenging to find a better color, we have already changed it 3 times (see #2267, #3625 and #3548) - so I would recommend trying a different pitch color instead.

@jgruca
Copy link
Contributor Author

jgruca commented Jun 6, 2022

I've updated the color to #88e0be per your suggestion. The images in the initial comment have also been updated.

@pnorman pnorman requested a review from jeisenbe August 1, 2022 04:09
Copy link
Collaborator

@imagico imagico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had not noticed this had been changed to use the color from the AC-style. This seems fine to me now, maybe a tiny bit too strong because OSM-Carto uses somewhat weaker colors overall than the AC-style. But that is something that should be reconsidered anyway (#3647) so this is completely fine as a subtle move in that direction.

I am sorry for the long time it took to review this - it somehow slipped my attention.

@imagico imagico dismissed jeisenbe’s stale review October 29, 2023 12:19

Review was about different color

@imagico imagico merged commit 4abe70d into gravitystorm:master Oct 29, 2023
@imagico imagico mentioned this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[suggestion] golf course colors - recent change - color for putting greens should be more green
4 participants