-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use common Single Quotes for Strings #4939
Use common Single Quotes for Strings #4939
Conversation
Have you tested this? |
No |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs testing - yes, this kind of change should not affect rendering - but we know from experience that Carto can be fairly particular when interpreting code - so we should not make assumptions here.
Regarding the idea of establishing stricter conventions on MSS coding - i am not opposed, but i think this should be documented in our coding guidelines then.
Ok, i have tested it now by calling |
I have also updated the coding guidelines. |
@imagico I have seen now, you are also a maintainer. So i may ask you, what is left to do to make this PR merged? |
Fixes NO issue, just cosmetic change
Changes proposed in this pull request:
Test rendering with links to the example places:
carto
; the generatedproject.xml
files before and after are identical