Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative to pnorman's building style #590

Closed
wants to merge 4 commits into from
Closed

Alternative to pnorman's building style #590

wants to merge 4 commits into from

Conversation

vholten
Copy link
Contributor

@vholten vholten commented Jun 1, 2014

In #565, @pnorman presented a style that results in lighter buildings, which I think is an improvement. However, the lighter buildings were not visible enough on residential and industrial landuse. I have taken the liberty of making some changes to pnorman's style so that buildings look better on these types of landuse. (If there is no landuse, the rendering is the same as in #565.) In this way, there is no need to change landuse colors.

Comparison to pnorman's style

Left is pnorman's style from #565, right is the changed style

Buildings on industrial

ind_pnormanbuildings ind_vholtenbuildings

Buildings on residential

res_pnormanbuildings res_vholtenbuildings

Buildings without landuse (no difference)

empty_pnormanbuildings empty_vholtenbuildings

pnorman and others added 4 commits May 24, 2014 20:41
Replace the old buildings SQL and MSS. This involves resulting changes to landcover stylings to handle landcover which was previously in buildings.mss.

Stops rendering supermarkets in a crazy pink to fix #520. Superceeds #550.

Moves the rendering of train station areas to landcover. Fixes #327. Fixes #389

Removes outline differences based on a distinction that no one fully understands. Superceeds #533. Fixes #68
@pnorman
Copy link
Collaborator

pnorman commented Jun 1, 2014

I toyed around with transparency, but couldn't really make it work. The problem is the colour looked like mud on some background. This looks better than what I had with transparency

How do these look on the stronger backgrounds, like green, or on the more differing ones like landuse=retail/commercial?

@pnorman
Copy link
Collaborator

pnorman commented Jun 1, 2014

@vholten If you want I can render a preview for it too, let me know when/if you feel its ready for that.

@gravitystorm
Copy link
Owner

Please, no transparency on buildings (and we should avoid translucent fills in general). I agree this PR makes the end result nicer, but similar effects can be achieved by having a non-transparent building fill and adjusting the over-colourful landuse colours instead.

@pnorman
Copy link
Collaborator

pnorman commented Jun 2, 2014

Please, no transparency on buildings (and we should avoid translucent fills in general).

Any thoughts on different comp-ops, or do they have the same issues?

@vholten
Copy link
Contributor Author

vholten commented Jun 2, 2014

Thank you all for your comments. I thought that adding transparency was worth a try, but since @gravitystorm has ruled it out, we should consider alternatives like changing the landuse colors.

@vholten vholten closed this Jun 2, 2014
@matthijsmelissen
Copy link
Collaborator

@vholten thank you for your contributions, and thank you all for the civil discussion!

@vholten vholten deleted the buildings_rewrite branch June 13, 2014 17:25
@matthijsmelissen
Copy link
Collaborator

Please, no transparency on buildings (and we should avoid translucent fills in general).

Another weird effect of transparency on buildings: link

Question: why is the sports centre rendered gray? Answer: because the transparent purple/brown overlay of the buildings on top of the bright green of the sport complex landcover results in gray...

@matthijsmelissen
Copy link
Collaborator

I slowly start suspecting now that that was the reason for picking that ridiculous colour of green in the first place!? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants